From 2368652fd3027a53f4dafaf01f9a009debf0a248 Mon Sep 17 00:00:00 2001
From: Aishani Bhalla <aishani.bhalla0709@gmail.com>
Date: Thu, 27 Apr 2023 22:42:07 -0700
Subject: [PATCH] Rename and define models for ncd MOE script (#2237)

* rename models for ncd scenario

* fix lightgbm model name

---------

Co-authored-by: Aishani Bhalla <aibhalla@microsoft.com>
---
 cli/deploy-managed-online-endpoint-ncd.sh     | 19 +++++++++++++------
 .../online/ncd/lightgbm-deployment.yaml       |  2 +-
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/cli/deploy-managed-online-endpoint-ncd.sh b/cli/deploy-managed-online-endpoint-ncd.sh
index b01dfc4607..7cd09d52ae 100644
--- a/cli/deploy-managed-online-endpoint-ncd.sh
+++ b/cli/deploy-managed-online-endpoint-ncd.sh
@@ -6,8 +6,12 @@ export ENDPOINT_NAME="<YOUR_ENDPOINT_NAME>"
 
 #  endpoint name
 export ENDPOINT_NAME=endpt-ncd-`echo $RANDOM`
-AML_MODEL_NAME=mir-sample-sklearn-ncd-model
-echo $AML_MODEL_NAME
+
+AML_SKLEARN_MODEL_NAME=mir-sample-sklearn-ncd-model
+echo $AML_SKLEARN_MODEL_NAME
+
+AML_LIGHTGBM_MODEL_NAME=mir-sample-lightgbm-ncd-model
+echo $AML_LIGHTGBM_MODEL_NAME
 
 # <create_endpoint>
 az ml online-endpoint create --name $ENDPOINT_NAME -f endpoints/online/ncd/create-endpoint.yaml
@@ -24,8 +28,10 @@ else
   exit 1
 fi
 
-# cleanup of existing model
-model_archive=$(az ml model archive -n $AML_MODEL_NAME --version 1 || true)
+# cleanup of existing models
+model_archive=$(az ml model archive -n $AML_SKLEARN_MODEL_NAME --version 1 || true)
+model_archive=$(az ml model archive -n $AML_LIGHTGBM_MODEL_NAME --version 1 || true)
+
 
 # <create_sklearn_deployment>
 az ml online-deployment create --name sklearn-deployment --endpoint $ENDPOINT_NAME -f endpoints/online/ncd/sklearn-deployment.yaml --all-traffic
@@ -63,8 +69,9 @@ fi
 az ml online-endpoint invoke --name $ENDPOINT_NAME --deployment lightgbm-deployment --request-file endpoints/online/ncd/sample-request-lightgbm.json
 # </test_lightgbm_deployment>
 
-# cleanup of model
-model_archive=$(az ml model archive -n $AML_MODEL_NAME --version 1 || true)
+# cleanup of models
+model_archive=$(az ml model archive -n $AML_SKLEARN_MODEL_NAME --version 1 || true)
+model_archive=$(az ml model archive -n $AML_LIGHTGBM_MODEL_NAME --version 1 || true)
 
 # <delete_endpoint>
 az ml online-endpoint delete --name $ENDPOINT_NAME --yes 
diff --git a/cli/endpoints/online/ncd/lightgbm-deployment.yaml b/cli/endpoints/online/ncd/lightgbm-deployment.yaml
index 636a9e0cab..1ac18ed42e 100644
--- a/cli/endpoints/online/ncd/lightgbm-deployment.yaml
+++ b/cli/endpoints/online/ncd/lightgbm-deployment.yaml
@@ -2,7 +2,7 @@ $schema: https://azuremlschemas.azureedge.net/latest/managedOnlineDeployment.sch
 name: lightgbm-deployment
 endpoint_name: my-endpoint
 model:
-  name: mir-sample-lightgbm-mlflow-model
+  name: mir-sample-lightgbm-ncd-model
   version: 1
   path: lightgbm-iris/model
   type: mlflow_model