Skip to content

Conversation

@viananth
Copy link
Member

No description provided.

@viananth viananth requested review from TheOnlyWei and bganapa May 29, 2020 01:14
@TheOnlyWei
Copy link
Contributor

Bala suggested moving $envFile from the tests to the common.ps1 file, but I tried that by adding $global:envFile to the common.ps1 file but that started throwing errors that does not seem to be related to the variable change and so would have been difficult to debug, so I put it back in my PR. What are your thoughts?

@viananth
Copy link
Member Author

Bala suggested moving $envFile from the tests to the common.ps1 file, but I tried that by adding $global:envFile to the common.ps1 file but that started throwing errors that does not seem to be related to the variable change and so would have been difficult to debug, so I put it back in my PR. What are your thoughts?

@TheOnlyWei Xiaogang suggested this work around for the above issue:

If you need to add a default parameter, you should do it in the setEnv function in utils.ps1.

You may refer to https://github.com/Azure/azure-powershell/blob/generation/src/Databricks/test/utils.ps1 as an example.

@bganapa
Copy link
Member

bganapa commented Jun 19, 2020

@viananth could you please merge this? you should have permissions, prefer Rebase and Merge option

@viananth
Copy link
Member Author

Tests passed. Pipeline failed at publish artifact step. Merging now.

@viananth viananth merged commit a360b48 into master Jun 24, 2020
@bganapa bganapa deleted the pipeline branch January 11, 2021 02:46
bganapa pushed a commit that referenced this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants