Skip to content

Commit 581ab01

Browse files
authored
fix msrc vuln (#360)
* removed inc/c_util/logging_stacktrace.h which is not needed * fix MSRC reported vuln * Revert "removed inc/c_util/logging_stacktrace.h which is not needed" This reverts commit b02ce4a. * Reapply "removed inc/c_util/logging_stacktrace.h which is not needed" This reverts commit 5a7ff33.
1 parent f7254e1 commit 581ab01

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

‎src/constbuffer_array.c‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -162,12 +162,11 @@ IMPLEMENT_MOCKABLE_FUNCTION(, CONSTBUFFER_ARRAY_HANDLE, constbuffer_array_create
162162
}
163163
else if (
164164
/* Codes_SRS_CONSTBUFFER_ARRAY_42_011: [ If start_buffer_index is greater than the number of buffers in original then constbuffer_array_create_from_buffer_index_and_count shall fail and return NULL. ]*/
165-
start_buffer_index > original->nBuffers ||
165+
(start_buffer_index > original->nBuffers) ||
166166
/* Codes_SRS_CONSTBUFFER_ARRAY_42_012: [ If start_buffer_index + buffer_count is greater than the number of buffers in original then constbuffer_array_create_from_buffer_index_and_count shall fail and return NULL. ]*/
167-
start_buffer_index + buffer_count > original->nBuffers
167+
buffer_count > original->nBuffers - start_buffer_index
168168
)
169169
{
170-
171170
LogError("Invalid arguments: CONSTBUFFER_ARRAY_HANDLE original=%p (nBuffers=%" PRIu32 "), uint32_t start_buffer_index=%" PRIu32 ", uint32_t buffer_count=%" PRIu32,
172171
original, original->nBuffers, start_buffer_index, buffer_count);
173172
result = NULL;

0 commit comments

Comments
 (0)