Add HotChocolate 12.18.0 MIT license and BCP ChilliCream License 1.0 to NOTICE.txt #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seantleonard
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
junsu0ms,
mbhaskar,
milismsft,
ravishetye,
severussundar and
tarazou9
as code owners
Aniruddh25
reviewed
Feb 27, 2023
Aniruddh25
reviewed
Feb 27, 2023
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
Aniruddh25
requested changes
Feb 27, 2023
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
Need to supplement the NOTICE.txt getting generated in the pipeline
…TICE file. Also adds build task to execute the script.
…e/data-api-builder into dev/seleonar/bcp_newlicense
…e/data-api-builder into dev/seleonar/bcp_newlicense
…tifacts build task.
Aniruddh25
reviewed
Feb 28, 2023
Aniruddh25
reviewed
Feb 28, 2023
…er and updated buildpipeline yaml to reflect new script location.
…e/data-api-builder into dev/seleonar/bcp_newlicense
Aniruddh25
reviewed
Feb 28, 2023
Aniruddh25
reviewed
Feb 28, 2023
…owershell. quick fix.
…e/data-api-builder into dev/seleonar/bcp_newlicense
1 task
Aniruddh25
reviewed
Mar 1, 2023
Aniruddh25
approved these changes
Mar 1, 2023
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
Thanks for resolving the ambiguities involved in this change to finally get the right solution!
LGTM.
nit: the PR description should be updated to reflect latest changes - no manual NOTICE, the link to the build is old
Contributor
Author
|
updated the pr description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
How was this change validated?