Support AAD User authentication for Azure MySQL Service #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aniruddh25
reviewed
Oct 27, 2022
Aniruddh25
reviewed
Oct 27, 2022
junsu0ms
requested review from
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
jarupatj,
mbhaskar,
milismsft,
seantleonard,
severussundar and
tarazou9
as code owners
Aniruddh25
reviewed
Oct 28, 2022
Aniruddh25
reviewed
Oct 28, 2022
Aniruddh25
reviewed
Oct 28, 2022
Aniruddh25
approved these changes
Oct 28, 2022
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
LGTM, left a few questions. Thanks for doing this!
aaronburtle
reviewed
Oct 28, 2022
aaronburtle
approved these changes
Oct 28, 2022
Contributor
aaronburtle
left a comment
aaronburtle
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fast change!
seantleonard
reviewed
Nov 2, 2022
Contributor
Author
|
Let me verify this in the real azure mysql server before I commit this. |
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
Co-authored-by: aaronburtle <93220300+aaronburtle@users.noreply.github.com>
Co-authored-by: Sean Leonard <sean.leonard@microsoft.com>
seantleonard
reviewed
Dec 1, 2022
seantleonard
approved these changes
Dec 1, 2022
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
needs one more DataRow in a test to utilize all code paths, then should be good.
Aniruddh25
reviewed
Dec 3, 2022
Aniruddh25
approved these changes
Dec 3, 2022
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
LGTM, once confirming InteractiveCredential is not needed.
Aniruddh25
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Support AAD User authentication for MySQL
What is this change?
Add user token as password field to authenticate with MySQL with AAD plugin
How was this tested?