feat(notifications) upload, download, delete notifications #172

Merged
merged 1 commit into from Jul 8, 2015

Projects

None yet

2 participants

@sedouard
Contributor
sedouard commented Jul 8, 2015

rebase in progress...

@sedouard
Contributor
sedouard commented Jul 8, 2015

Biggest change is breaking the notification object out of the notification controller (no factory function). For future batch notification implementation.

Implemented promise notification, the azure sdk requires us to poll the a speedSummary object it returns I had to do some finagling to get that to work with notifications using window.timer. patched up your unit tests for the changes and added an integration test to test the notifications (basically) work�.

@felixrieseberg
Contributor

Awesome stuff. I can probably get a bit more performance out of it here and there (not because I'm a genius, just because I have a second pair of 👀), but I feel like I can just do that in an additional PR.

@felixrieseberg felixrieseberg merged commit 4f2ab2f into Azure:master Jul 8, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment