Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watch feature not watching for changes #341

Open
bacongobbler opened this issue Sep 18, 2017 · 4 comments

Comments

@bacongobbler
Copy link
Member

commented Sep 18, 2017

It looks like the watch feature in Draft does not work at all. When I make changes to an application with watch enabled, no builds are reported or uploaded to tiller.

@fibonacci1729 fibonacci1729 self-assigned this Sep 19, 2017

@fibonacci1729 fibonacci1729 added the wip label Sep 20, 2017

@michelleN michelleN added this to Backlog in v1 Jan 11, 2018

@michelleN michelleN added this to the 0.13.0 milestone Jan 11, 2018

@bacongobbler bacongobbler moved this from Backlog to Alpha in v1 Jan 19, 2018

@pikeas

This comment has been minimized.

Copy link

commented Mar 23, 2018

Just discovered draft and this seems like a deal breaker for use in any real dev environment...

@squillace

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2018

@pikeas yep, and we're just about to fix that, as I understand. Us, too. All though it turns out we get very different feedback from different dev types.

@bacongobbler

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2018

removing this from the milestone in favour of the VSCode "draft up on save" experience. The existing file watcher libraries are all very buggy. VSCode has got the right experience.

See Azure/vscode-kubernetes-tools#160 for a work-in-progress implementation running draft up when a file is saved.

@bacongobbler bacongobbler removed this from the 0.13.0 milestone Apr 3, 2018

@bacongobbler bacongobbler removed the wip label Apr 3, 2018

@bacongobbler

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2018

I'm almost in favour of removing the file watcher from Draft entirely and handing this off to the IDE to handle for us. That would be a good move forward for users: they get the experience they want, and we can revisit this when there are more stable file watcher libs available for use (or we write one ourselves).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants
You can’t perform that action at this time.