Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Existing AzureChinaCloud Exemptions not Returning Non-Management Group Scoped Exemptions #691

Closed
ahsulli opened this issue Jun 25, 2024 · 7 comments · Fixed by #702
Closed
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@ahsulli
Copy link
Contributor

ahsulli commented Jun 25, 2024

Describe the bug
When getting existing exemptions within an AzureChinaCloud tenant, only management group level exemptions are included in the final returned list of existing exemptions.

To Reproduce

  1. Run an Export-AzPolicyResources or Build-DeploymentPlans using a pacSelector whose type is AzureChinaCloud.

Expected behavior
All exemptions scoped to management groups, subscriptions, resource groups, and individual resources within the specified pacSelector configuration should be included in the list of existing exemptions that are factored into the final output.

Screenshots
N/A

EPAC Version
10.3.5

@ahsulli ahsulli added the bug Something isn't working label Jun 25, 2024
@ahsulli ahsulli changed the title Export and Get Existing AzureChinaCloud Exemptions not Working Get Existing AzureChinaCloud Exemptions not Returning Non-Management Group Scoped Exemptions Jun 25, 2024
@anwather anwather self-assigned this Jun 25, 2024
@anwather
Copy link
Collaborator

Closing as issue is defined in #692

@anwather anwather added the duplicate This issue or pull request already exists label Jun 25, 2024
@ahsulli
Copy link
Contributor Author

ahsulli commented Jul 8, 2024

@anwather, just to further clarify, you can also reproduce this issue by running Build-DeploymentPlans as well. However, this version of the repro steps produces an erroneous output that is less obvious to see but is still flawed for the same reason.

@ahsulli
Copy link
Contributor Author

ahsulli commented Jul 9, 2024

@anwather, issue is still present. Please fix. Cannot run deployment plans against China tenants as a result.

@anwather
Copy link
Collaborator

anwather commented Jul 9, 2024 via email

@ahsulli
Copy link
Contributor Author

ahsulli commented Jul 11, 2024

@anwather, can someone please grant me access to create a branch and PR? I have the code already prepared on my local. The code has been successfully tested numerous times against my organization's China and Commercial tenants. Hopefully that helps too.

@anwather
Copy link
Collaborator

anwather commented Jul 11, 2024 via email

@ahsulli
Copy link
Contributor Author

ahsulli commented Jul 16, 2024

@anwather, I have created PR: #702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
2 participants