New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent Refactoring to Long Running Operations #193

Closed
tombuildsstuff opened this Issue Nov 7, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@tombuildsstuff
Contributor

tombuildsstuff commented Nov 7, 2017

馃憢

I've seen this recent PR which changes the way that Long Running Operations are handled, such that it effectively removes the polling support from the SDK and instead pushed that onto consumers of the SDK.

Within Terraform, we rely pretty heavily on the automatic polling available within the Go SDK - as such I'm concerned that removing these methods will lead to a considerable increase in code (and thus complexity) for us - when currently this is one of the major benefits of using the Go SDK over when we used to use the Riviera SDK.

As such - are there any plans around to expose a polling method available within the SDK to preserve the current behaviour? I can certainly see the desire for the SDK to return the current state - however polling until the resource is ready is also a really handy function of the SDK at this point :)

Thanks!

@jhendrixMSFT jhendrixMSFT self-assigned this Nov 7, 2017

@jhendrixMSFT

This comment has been minimized.

Show comment
Hide comment
@jhendrixMSFT

jhendrixMSFT Nov 7, 2017

Member

This was something I was thinking about last week. Adding a method to the future that waits until completion would be pretty trivial, @tombuildsstuff would this work for you?

Member

jhendrixMSFT commented Nov 7, 2017

This was something I was thinking about last week. Adding a method to the future that waits until completion would be pretty trivial, @tombuildsstuff would this work for you?

@tombuildsstuff

This comment has been minimized.

Show comment
Hide comment
@tombuildsstuff

tombuildsstuff Nov 7, 2017

Contributor

@jhendrixMSFT yep, that would be great 馃憤

Thanks!

Contributor

tombuildsstuff commented Nov 7, 2017

@jhendrixMSFT yep, that would be great 馃憤

Thanks!

@jhendrixMSFT jhendrixMSFT referenced this issue Nov 7, 2017

Merged

Add WaitForCompletion to Future type. #194

2 of 4 tasks complete
@jhendrixMSFT

This comment has been minimized.

Show comment
Hide comment
@jhendrixMSFT

jhendrixMSFT Nov 9, 2017

Member

This has been added in go-autorest v9.4.0.

Member

jhendrixMSFT commented Nov 9, 2017

This has been added in go-autorest v9.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment