This repository was archived by the owner on Feb 18, 2021. It is now read-only.
Show toast on data source error#132
Merged
morsh merged 2 commits intoAzure:ibex-version-1.0from May 21, 2017
c-w:bugfix-83
Merged
Show toast on data source error#132morsh merged 2 commits intoAzure:ibex-version-1.0from c-w:bugfix-83
morsh merged 2 commits intoAzure:ibex-version-1.0from
c-w:bugfix-83
Conversation
morsh
reviewed
May 18, 2017
Contributor
morsh
left a comment
morsh
left a comment
There was a problem hiding this comment.
Just this small fix, and I can merge this.
Very cool you took this on
| private errorToMessage(error: any): string { | ||
| const exception = error as Error; | ||
| if (exception == null) { | ||
| return error; |
Contributor
Author
There was a problem hiding this comment.
This was actually a misunderstanding on my part how as works in TypeScript. I assumed that it worked like in C# (try a cast and if it's not castable, return null). Fixed in 5961bc7 by using instanceof.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83
Example error displayed when the connection to the data-source failed: