This repository was archived by the owner on Feb 18, 2021. It is now read-only.
Run tslint on Travis#166
Merged
c-w merged 1 commit intoAzure:ibex-version-1.0from Jun 12, 2017
c-w:travis-ci
Merged
Conversation
Contributor
Author
|
CI now set up for ibex-dashboard on the Travis site. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds basic integration with Travis CI.
The CI will still have to be enabled by an admin of the ibex-dashboard repository on the Travis site. I recommend the following setup which we use on fortis-insights:
For now, the only CI that is being run is the linter, but adding other tasks on the CI is easy, just a matter of adding another
NPM_COMMANDto the env section. Using the env section instead of the scripts section has two advantages: (1) the tasks will get run in parallel instead of in sequence (2) it's easier to see what caused the build to fail, e.g. test issue or lint issue.