Skip to content
This repository has been archived by the owner. It is now read-only.

Add auto-update functionality to all data sources #169

Merged
merged 8 commits into from Jun 22, 2017

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jun 12, 2017

This pull request adds an optional property to the dashboard data sources: autoUpdateIntervalMs. If this property is set, the data source will refetch its query at the interval defined by the property. For example, to re-fetch the results for an application insights query twice per second, we'd start our data source configuration like this:

image

Paired with @eladiw

@morsh morsh changed the base branch from master to ibex-version-1.0 Jun 14, 2017
@@ -31,7 +31,7 @@ export interface IDataSourcePlugin {
};

bind (actionClass: any): void;
updateDependencies (dependencies: IDictionary, args: IDictionary, callback: () => void): void;
_updateDependencies (dependencies: IDictionary, args: IDictionary, callback: () => void): void;
Copy link
Contributor

@itye-msft itye-msft Jun 21, 2017

I believe that our naming convention for class functions don't use underscore prefix "_"

Copy link
Contributor Author

@c-w c-w Jun 21, 2017

This was done to indicate a private wrapper. I've renamed to make this more explicit in c4c5c0e.

@itye-msft itye-msft changed the base branch from ibex-version-1.0 to ibex-version-1.0-hackfest-merge Jun 22, 2017
@itye-msft itye-msft changed the base branch from ibex-version-1.0-hackfest-merge to ibex-version-1.0-merge-auto-update Jun 22, 2017
@itye-msft itye-msft merged commit 537c5ff into ibex-version-1.0-merge-auto-update Jun 22, 2017
2 checks passed
@morsh
Copy link
Contributor

@morsh morsh commented Jun 22, 2017

@itye-msft - since these are abstract methods and are implemented as part of various components, updateDependenciesInternal does not work.

Please rename to something more descriptive like "dependenciesUpdated"

@itye-msft
Copy link
Contributor

@itye-msft itye-msft commented Jun 22, 2017

@morsh
agreed and done.

@c-w c-w deleted the auto-update branch Jun 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants