This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Add auto-update functionality to all data sources #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itye-msft
reviewed
Jun 21, 2017
| @@ -31,7 +31,7 @@ export interface IDataSourcePlugin { | |||
| }; | |||
|
|
|||
| bind (actionClass: any): void; | |||
| updateDependencies (dependencies: IDictionary, args: IDictionary, callback: () => void): void; | |||
| _updateDependencies (dependencies: IDictionary, args: IDictionary, callback: () => void): void; | |||
There was a problem hiding this comment.
I believe that our naming convention for class functions don't use underscore prefix "_"
There was a problem hiding this comment.
This was done to indicate a private wrapper. I've renamed to make this more explicit in c4c5c0e.
itye-msft
changed the base branch from
ibex-version-1.0
to
ibex-version-1.0-hackfest-merge
itye-msft
changed the base branch from
ibex-version-1.0-hackfest-merge
to
ibex-version-1.0-merge-auto-update
|
@itye-msft - since these are abstract methods and are implemented as part of various components, updateDependenciesInternal does not work. Please rename to something more descriptive like "dependenciesUpdated" |
|
@morsh |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an optional property to the dashboard data sources: autoUpdateIntervalMs. If this property is set, the data source will refetch its query at the interval defined by the property. For example, to re-fetch the results for an application insights query twice per second, we'd start our data source configuration like this:
Paired with @eladiw