Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings #175

Merged
merged 3 commits into from Jun 21, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Contributor

commented Jun 15, 2017

This pull request fixes two compiler warnings that cause the build to fail on the CI server where warnings are treated as errors (we currently manually silence this break):

  1. We now move all .d.ts typings files to the @types directory so that the typescript compiler doesn't try to generate empty js files from them.
  2. We disable a tslint check that was broken by a recent typescript version update and therefore now causes a compiler warning.

@c-w c-w requested a review from morsh Jun 15, 2017

@itye-msft itye-msft changed the base branch from ibex-version-1.0 to ibex-version-1.0-hackfest-merge Jun 21, 2017

@itye-msft itye-msft merged commit 9d2b0cb into ibex-version-1.0-hackfest-merge Jun 21, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the fix-compiler-warnings branch Jun 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.