Skip to content
This repository was archived by the owner on Feb 18, 2021. It is now read-only.

Fix compiler warnings#175

Merged
itye-msft merged 3 commits intoibex-version-1.0-hackfest-mergefrom
fix-compiler-warnings
Jun 21, 2017
Merged

Fix compiler warnings#175
itye-msft merged 3 commits intoibex-version-1.0-hackfest-mergefrom
fix-compiler-warnings

Conversation

@c-w
Copy link
Copy Markdown
Contributor

@c-w c-w commented Jun 15, 2017

This pull request fixes two compiler warnings that cause the build to fail on the CI server where warnings are treated as errors (we currently manually silence this break):

  1. We now move all .d.ts typings files to the @types directory so that the typescript compiler doesn't try to generate empty js files from them.
  2. We disable a tslint check that was broken by a recent typescript version update and therefore now causes a compiler warning.

@c-w c-w requested a review from morsh June 15, 2017 14:01
@itye-msft itye-msft changed the base branch from ibex-version-1.0 to ibex-version-1.0-hackfest-merge June 21, 2017 13:38
@itye-msft itye-msft merged commit 9d2b0cb into ibex-version-1.0-hackfest-merge Jun 21, 2017
@c-w c-w deleted the fix-compiler-warnings branch June 21, 2017 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants