New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to value.yaml and deployment.yaml with breaking changes for provider deployment #21

Merged
merged 10 commits into from Nov 10, 2018

Conversation

Projects
None yet
3 participants
@neumanndaniel
Member

neumanndaniel commented Nov 6, 2018

Update deployment.yaml with breaking changes

If you are using the latest Virtual Kubelet image you get the following notification in the logs:
Flag --taint has been deprecated, Taint key should now be configured using the VK_TAINT_KEY environment variable

So, the changes introduced are breaking changes, because the node taint has to be modified and some other spaces like the Virtual Kubelet port.

Furthermore a nodeSelector was added to make sure that the IoT Edge Provider will land on a Linux node in Kubernetes cluster with multiple agent pools having different node OS types.

Update value.yaml with breaking changes

So, the value.yaml is reflecting the changes that are made in the deployment.yaml.

rbac.install is switched now from false to true, because AKS cluster are deployed per default with Kubernetes RBAC enabled.

vk.image.tag is switched to latest from 0.3 to reflect the changes that are made to the deployment.yaml

Added the taint section.

neumanndaniel added some commits Jul 17, 2018

Merge pull request #1 from Azure/master
Sync fork with master
Update deployment.yaml with breaking changes
If you are using the latest Virtual Kubelet image you get the following notification in the logs:
Flag --taint has been deprecated, Taint key should now be configured using the VK_TAINT_KEY environment variable

So, the changes introduced are breaking changes, because the node taint has to be modified and some other spaces like the Virtual Kubelet port.

Furthermore a nodeSelector was added to make sure that the IoT Edge Provider will land on a Linux node in Kubernetes cluster with multiple agent pools having different node OS types.
Update value.yaml with breaking changes
If you are using the latest Virtual Kubelet image you get the following notification in the logs:
Flag --taint has been deprecated, Taint key should now be configured using the VK_TAINT_KEY environment variable

So, the value.yaml is reflecting the changes that are made in the deployment.yaml.

rbac.install is switched now from false to true, because AKS cluster are deployed per default with Kubernetes RBAC enabled.

vk.image.tag is switched to latest from 0.3 to reflect the changes that are made to the deployment.yaml

Added the taint section.
@neumanndaniel

This comment has been minimized.

Member

neumanndaniel commented Nov 6, 2018

I will update the example .yaml files for container deployment in the next days.

@avranju

avranju approved these changes Nov 8, 2018

enabled: true
key: virtual-kubelet.io/provider
value: iotedge
# 'effect' must be 'NoSchedule`, 'PreferNoSchedule' or 'NoExecute'.

This comment has been minimized.

@avranju

avranju Nov 8, 2018

Member

I suppose in our case we really want this to be NoSchedule :)

This comment has been minimized.

@neumanndaniel

neumanndaniel Nov 8, 2018

Member

Doesn't matter. NoSchedule is the preferred one, but the other one's also work. So, I would leave as it is right now with the comment.

This comment has been minimized.

@avranju

avranju Nov 8, 2018

Member

Doesn't PreferNoSchedule mean that the controller will only try not to schedule pods on this node? So there's a possibility that it might still happen?

This comment has been minimized.

@neumanndaniel

neumanndaniel Nov 9, 2018

Member

From the K8s docs:

  • if there is at least one un-ignored taint with effect NoSchedule then Kubernetes will not schedule the pod onto that node

  • if there is no un-ignored taint with effect NoSchedule but there is at least one un-ignored taint with effect PreferNoSchedule then Kubernetes will try to not schedule the pod onto the node

  • if there is at least one un-ignored taint with effect NoExecute then the pod will be evicted from the node (if it is already running on the node), and will not be scheduled onto the node (if it is not yet running on the node).

In the end you are correct, that it might still happen. I will update it to NoSchedule or NoExecute

Show resolved Hide resolved src/charts/iot-edge-connector/values.yaml
Update README.md
Reflecting the changes from the following PR #21

@neumanndaniel neumanndaniel referenced this pull request Nov 8, 2018

Merged

Update README.md #2

neumanndaniel added some commits Nov 8, 2018

Update sample-deployment.yaml
Reflecting the changes from the following PR #21
Update sample-pod.yaml
Reflecting the changes from the following PR #21

Updating the container image to the GA version.
Merge pull request #2 from neumanndaniel/neumanndaniel-patch-1
Reflecting the changes from the following PR #21
@neumanndaniel

This comment has been minimized.

Member

neumanndaniel commented Nov 8, 2018

Updated the README.md and the sample-deployment.yaml and sample-pod.yaml to reflect the initial proposed changes for the IoT Edge Provider deployments.

neumanndaniel added some commits Nov 8, 2018

Update values.yaml
Comment updates
@veyalla

LGTM. Thanks for your contribution Daniel!

@veyalla veyalla merged commit 520cdd1 into Azure:master Nov 10, 2018

1 check passed

license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment