Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt] Make tracing looks like edgehub logs again #4851

Merged
merged 3 commits into from Apr 16, 2021

Conversation

dmolokanov
Copy link
Contributor

@dmolokanov dmolokanov commented Apr 15, 2021

Bring back edgehub-like tracing logs after upgrade.

I added additional features which adds styling to log entries by it looks bag for logs inside container. It can be enabled with adding ansi feature when compiled

@vadim-kovalyov
Copy link
Contributor

Bring back edgehub-like tracing logs after upgrade.

I added additional features which adds styling to log entries by it looks bag for logs inside container. It can be enabled with adding ansi feature when compiled

@dmolokanov, do you have a "before/after" example?

Copy link
Contributor

@vadim-kovalyov vadim-kovalyov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dmolokanov
Copy link
Contributor Author

Bring back edgehub-like tracing logs after upgrade.
I added additional features which adds styling to log entries by it looks bag for logs inside container. It can be enabled with adding ansi feature when compiled

@dmolokanov, do you have a "before/after" example?

Something like this

w/ ansi

[2mApr 14 18:31:14.838�[0m �[32m INFO�[0m mqttd::app::edgehub: loading settings from a file /app/mqttd/broker.json

w/o ansi

Apr 14 18:31:14.838 INFO mqttd::app::edgehub: loading settings from a file /app/mqttd/broker.json

@kodiakhq kodiakhq bot merged commit 944f909 into Azure:master Apr 16, 2021
@dmolokanov dmolokanov deleted the tracing-upgrade branch April 16, 2021 15:10
ggjjj pushed a commit to ggjjj/iotedge that referenced this pull request Jul 22, 2021
Bring back edgehub-like tracing logs after upgrade.

I added additional features which adds styling to log entries by it looks bag for logs inside container. It can be enabled with adding `ansi` feature when compiled
damonbarry pushed a commit to damonbarry/iotedge that referenced this pull request Apr 15, 2022
Bring back edgehub-like tracing logs after upgrade.

I added additional features which adds styling to log entries by it looks bag for logs inside container. It can be enabled with adding `ansi` feature when compiled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants