Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Remove documentation re: requiring Reader perms for SPN on KeyVault #147

Merged
merged 1 commit into from Dec 10, 2019

Conversation

lee0c
Copy link
Contributor

@lee0c lee0c commented Nov 15, 2019

Reason for Change:

Follow up to PR #128 - align documentation to update. Reader perm requirement was removed but docs still reference needing it.

Issue Fixed:

Related to already closed issue #78

Notes for Reviewers:
None

@ritazh
Copy link
Member

ritazh commented Nov 15, 2019

Thanks for the PR @lee0c 🎉 Instead of removing it altogether, can I request that you update the section with Optional if you are using version < v0.0.13. We are currently on v0.0.15 need to support older version at least for a bit longer. Added this issue to track: #149

@lee0c
Copy link
Contributor Author

lee0c commented Nov 15, 2019

Absolutely, good call out @ritazh . I'll do that now 👍

@lee0c
Copy link
Contributor Author

lee0c commented Dec 9, 2019

@ritazh Wanted to let you know that I updated this per your comment :)

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit a3b673f into Azure:master Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants