Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Ignore existing installation when running installPipPackageTask #895

Merged
merged 1 commit into from Jul 17, 2020

Conversation

jackgerrits
Copy link
Member

When iterating in a dev environment this ensures that it always overwrites the already installed version.

-I, --ignore-installed      Ignore the installed packages, overwriting them. This can break your system if the existing package is
                              of a different version or was installed with a different package manager!

@welcome
Copy link

welcome bot commented Jul 16, 2020

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. This helps us to create release messages and credit you for your hard work!
Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

Make sure to check out the developer guide for guidance on testing your change.

@jackgerrits jackgerrits changed the title Ignore existing installation when running installPipPackageTask build: Ignore existing installation when running installPipPackageTask Jul 16, 2020
@jackgerrits
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #895 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #895      +/-   ##
==========================================
+ Coverage   85.31%   85.36%   +0.05%     
==========================================
  Files         189      189              
  Lines        8769     8769              
  Branches      558      558              
==========================================
+ Hits         7481     7486       +5     
+ Misses       1288     1283       -5     
Impacted Files Coverage Δ
...com/microsoft/ml/spark/cognitive/RESTHelpers.scala 50.00% <0.00%> (-15.39%) ⬇️
...a/com/microsoft/ml/spark/io/http/HTTPClients.scala 73.21% <0.00%> (+16.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1b4a94...28c1f54. Read the comment docs.

@mhamilton723 mhamilton723 merged commit 54a623d into microsoft:master Jul 17, 2020
@welcome
Copy link

welcome bot commented Jul 17, 2020

Congrats on merging your first pull request, we appreciate your support! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants