Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guard against corrupted getToken function #58

Merged
merged 2 commits into from Sep 5, 2019

Conversation

@manekinekko
Copy link
Member

commented Sep 3, 2019

Pull Request Template

Description

This PR fixes the creds.getToken is not a function we started having recently.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@manekinekko manekinekko self-assigned this Sep 3, 2019

@manekinekko manekinekko requested a review from softchris Sep 3, 2019

@manekinekko manekinekko force-pushed the fix-gettoken branch 2 times, most recently from 1a14efa to a62b2b4 Sep 3, 2019

@manekinekko manekinekko force-pushed the fix-gettoken branch from a62b2b4 to 22ce166 Sep 4, 2019

@softchris softchris requested review from shmool and sinedied as code owners Sep 5, 2019

@softchris softchris merged commit 060b503 into master Sep 5, 2019

8 checks passed

Azure.ng-deploy-azure Build #20190905.1 succeeded
Details
Azure.ng-deploy-azure (Job linux-node10) Job linux-node10 succeeded
Details
Azure.ng-deploy-azure (Job linux-node8) Job linux-node8 succeeded
Details
Azure.ng-deploy-azure (Job mac-node10) Job mac-node10 succeeded
Details
Azure.ng-deploy-azure (Job mac-node8) Job mac-node8 succeeded
Details
Azure.ng-deploy-azure (Job windows-node10) Job windows-node10 succeeded
Details
Azure.ng-deploy-azure (Job windows-node8) Job windows-node8 succeeded
Details
license/cla All CLA requirements met.
Details

@sinedied sinedied deleted the fix-gettoken branch Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.