Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue where it generates names for all eternity #62

Merged
merged 4 commits into from Sep 5, 2019

Conversation

@softchris
Copy link
Member

commented Sep 3, 2019

Pull Request Template

Description

this fixes an issue where this piece of code ended up in while/true

function accountNameGenerator(client: StorageManagementClient) {
  return async (name: string) => {
    return await generateName(name, checkNameAvailability(client, false));
  };
}

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How to Test

  • place a console.log inside of checkNameAvailability() and you will see this being hit thousands of times

Closing issues

Closes #60

@softchris softchris requested a review from manekinekko Sep 3, 2019

@softchris softchris changed the title without this fix it will keep generating names for all eternity fix: issue where it generates names for all eternity Sep 4, 2019

softchris and others added 3 commits Sep 3, 2019

@manekinekko manekinekko requested review from shmool and sinedied as code owners Sep 5, 2019

@manekinekko manekinekko merged commit 192f38b into Azure:master Sep 5, 2019

8 checks passed

Azure.ng-deploy-azure Build #20190905.3 succeeded
Details
Azure.ng-deploy-azure (Job linux-node10) Job linux-node10 succeeded
Details
Azure.ng-deploy-azure (Job linux-node8) Job linux-node8 succeeded
Details
Azure.ng-deploy-azure (Job mac-node10) Job mac-node10 succeeded
Details
Azure.ng-deploy-azure (Job mac-node8) Job mac-node8 succeeded
Details
Azure.ng-deploy-azure (Job windows-node10) Job windows-node10 succeeded
Details
Azure.ng-deploy-azure (Job windows-node8) Job windows-node8 succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.