Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensuring we are checking the storage accounts on the whole subscripti… #65

Merged

Conversation

@softchris
Copy link
Member

commented Sep 3, 2019

…on instead of by resource group

Pull Request Template

Description

storage accounts are unique by subscription NOT by resource group. So when we check for a storage account we need to check the whole subscription otherwise we risk a name collision

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How to Test

  • try deploying a quickstart twice and you will get an error complaining about account name taken already

Closing issues

closes #64

Assignee

Please add yourself as the assignee

Projects

Please add relevant projects so this issue can be properly tracked.

@softchris softchris requested review from a-santamaria, manekinekko and shmool and removed request for a-santamaria Sep 3, 2019

src/util/azure/account.ts Outdated Show resolved Hide resolved
src/util/azure/account.ts Outdated Show resolved Hide resolved

@softchris softchris changed the title ensuring we are checking the storage accounts on the whole subscripti… fix: ensuring we are checking the storage accounts on the whole subscripti… Sep 4, 2019

@manekinekko manekinekko self-requested a review Sep 4, 2019

fix: remove not used code, fixing missing}, fixing how to retrieve ac…
…count now that we look at all storage accounts rather than by resource group
src/util/azure/account.ts Outdated Show resolved Hide resolved
softchris and others added 3 commits Sep 4, 2019

@manekinekko manekinekko merged commit 49b8f67 into Azure:master Sep 5, 2019

8 checks passed

Azure.ng-deploy-azure Build #20190905.4 succeeded
Details
Azure.ng-deploy-azure (Job linux-node10) Job linux-node10 succeeded
Details
Azure.ng-deploy-azure (Job linux-node8) Job linux-node8 succeeded
Details
Azure.ng-deploy-azure (Job mac-node10) Job mac-node10 succeeded
Details
Azure.ng-deploy-azure (Job mac-node8) Job mac-node8 succeeded
Details
Azure.ng-deploy-azure (Job windows-node10) Job windows-node10 succeeded
Details
Azure.ng-deploy-azure (Job windows-node8) Job windows-node8 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.