Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when using saved credentials #67

Merged
merged 2 commits into from Sep 6, 2019

Conversation

@sinedied
Copy link
Member

commented Sep 6, 2019

Pull Request Template

Description

Fix crash with creds.getToken error when you have saved credentials.

I also removed saving the credentials in CI mode, because that's a different kind of credentials object, ie ApplicationTokenCredentials vs DeviceTokenCredentials so loading this kind of credentials from cache won't work for now.
I suggest we use proper adapters for saving/loading credentials to avoid this kind of issues in the future, if we plan to support other auth methods.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
@manekinekko manekinekko referenced this pull request Sep 6, 2019
1 of 4 tasks complete

@manekinekko manekinekko merged commit 8b63d0b into master Sep 6, 2019

8 checks passed

Azure.ng-deploy-azure Build #20190906.2 succeeded
Details
Azure.ng-deploy-azure (Job linux-node10) Job linux-node10 succeeded
Details
Azure.ng-deploy-azure (Job linux-node8) Job linux-node8 succeeded
Details
Azure.ng-deploy-azure (Job mac-node10) Job mac-node10 succeeded
Details
Azure.ng-deploy-azure (Job mac-node8) Job mac-node8 succeeded
Details
Azure.ng-deploy-azure (Job windows-node10) Job windows-node10 succeeded
Details
Azure.ng-deploy-azure (Job windows-node8) Job windows-node8 succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.