Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix for issue #62 - Debugging query callback with node-inspector! #84

Merged
merged 1 commit into from

3 participants

@DMGambone

Per the comments from clintwood, the original line:
callback->Call(Undefined().As(), argc, args);
causes node-inspector to crash if breakpoints are added in any query
callback function. This change corrects that.

@DMGambone DMGambone Fix for issue #62 - Debugging query callback with node-inspector!
Per the comments from clintwood, the original line:
callback->Call(Undefined().As<Object>(), argc, args);
causes node-inspector to crash if breakpoints are added in any query
callback function.  This change corrects that.
a6d5f4c
@jguerin

Hi @DMGambone, could you please take a read of the contribution guidelines. We do require that you submit a Contributor License Agreement before we can accept code contributions. Let me know if you have any questions.

Thanks!

Jonathan

@DMGambone

Hi @jguerin,

The link to get the document doesn't work. Can you provide me with an alternative one?

Thanks

@jguerin

I've fixed the link. :)

@DMGambone

CLA is on it's way to MS

@jguerin

I've received the CLA and you are now listed as a contributor. @jkint will take a look at the change as soon as he is able.

Thanks!

Jonathan

@jkint jkint was assigned
@jkint jkint merged commit 3ce7df9 into from
@jkint jkint was unassigned by DMGambone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 16, 2012
  1. @DMGambone

    Fix for issue #62 - Debugging query callback with node-inspector!

    DMGambone authored
    Per the comments from clintwood, the original line:
    callback->Call(Undefined().As<Object>(), argc, args);
    causes node-inspector to crash if breakpoints are added in any query
    callback function.  This change corrects that.
This page is out of date. Refresh to see the latest.
Showing with 7 additions and 1 deletion.
  1. +7 −1 src/OdbcOperation.cpp
View
8 src/OdbcOperation.cpp
@@ -68,7 +68,13 @@ namespace mssql
argc = 2;
}
- callback->Call(Undefined().As<Object>(), argc, args);
+ //DMGambone: Implementing the fix that clintwood documented
+ //for issue #62 - Debugging query callback with node-inspector!
+ //The original line:
+ // callback->Call(Undefined().As<Object>(), argc, args);
+ //causes node-inspector to crash if breakpoints are added in any
+ //query callback function
+ callback->Call(Context::GetCurrent()->Global(), argc, args);
}
}
Something went wrong with that request. Please try again.