Update package.json to use common js properties #166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
hi @maxburs, I ran a quick test with package.json {
"name": "parcel-react-azure-maps",
"version": "1.0.0",
"description": "",
"main": "index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"author": "",
"license": "ISC",
"devDependencies": {
"parcel": "^2.9.3",
"process": "^0.11.10"
},
"dependencies": {
"azure-maps-control": "^3.0.0-preview.10",
"react": "^18.2.0",
"react-azure-maps": "^1.0.0-beta.3",
"react-dom": "^18.2.0"
}
}src/index.html <!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<title>My Parcel App</title>
</head>
<body>
<div id="app"></div>
<script type="module" src="index.js"></script>
</body>
</html>src/index.js import { createRoot } from "react-dom/client";
import { App } from "./App";
const container = document.getElementById("app");
const root = createRoot(container)
root.render(<App />);src/App.js import { AzureMap, AzureMapsProvider } from "react-azure-maps";
import "azure-maps-control/dist/atlas.min.css"
const option = {
zoom: 12,
center: [-122.335, 47.62],
authOptions: {
authType: "subscriptionKey",
subscriptionKey: "",
},
};
export function App() {
return (
<div style={{ height: "300px" }}>
<AzureMapsProvider>
<AzureMap options={option} />
</AzureMapsProvider>
</div>
);
}npx parcel src/index.html
|
Author
|
Looks like your right, sorry for the noise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moduleandexport/importare meant to reference es module files. Our bundler (Parcel) throws an error when parses react-azure-maps.es5.js an doesn't find any exports.Node docs on the "exports" property: https://nodejs.org/api/packages.html#conditional-exports. "main": https://nodejs.org/api/packages.html#main. "module" was a proposal that wasn't adopted and isn't officially supported. Some bundlers still use it.