-
Notifications
You must be signed in to change notification settings - Fork 36
feat: Vector Tile Source Support #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Vector Tile Source Support #90
Conversation
|
@ambientlight Can you also provide an example in playground and docs? |
msasinowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@psrednicki Please also take a look and make some smoke tests on it.
@msasinowski: Forgot about the docs, will add, thanks. Playground example is at Azure/react-azure-maps-playground#46 |
|
The docs PR is at WiredSolutions/react-azure-maps-docs#11 @msasinowski: let me know if all your comments are appropriately addressed, thanks! |
|
Its looks good - i added some minor comments. @ambientlight Thanks for contribution, you do great work! I need some time to do some smoke tests and probably finish it by the end of the week. |
|
I have test that and it looks good! Let's resolve theses comments and we can merge it. |
|
@psrednicki: thanks, should be all addressed now |
psrednicki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add support for vector tile source. Introduces no breaking changes via AzureMapDataSourceContext introducing another stateful provider wrapping
VectorTileSource.Example Usage: