Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.4.0 #104

Closed
wants to merge 8 commits into from
Closed

Release 0.4.0 #104

wants to merge 8 commits into from

Conversation

rayluo
Copy link
Contributor

@rayluo rayluo commented Dec 9, 2021

  • Enhancement: Make all platform-dependent parameters optional (Making all platform-dependent parameters optional #103)
  • Enhancement: Provide PersistenceEncryptError and PersistenceDecryptError, currently raised when encryption on Windows fails. (PR 108, currently under review)
  • Enhancement: The data file will be created with 600 permission when running in Unix-like systems. (PR 107)

@jiasli
Copy link
Contributor

jiasli commented Dec 9, 2021

We got a problem here.

azure-identity is used in Azure CLI by some modules owned by service team (though azure-cli-core doesn't depend on azure-identity), but azure-identity requires

https://github.com/Azure/azure-sdk-for-python/blob/4db8247d519b48051eb9f88d1c2c44949b6a45ba/sdk/identity/azure-identity/setup.py#L79

"msal-extensions~=0.3.0",

Azure CLI can't use msal-extensions 0.4.0, as it will cause conflict with azure-identity. @xiangyan99

@rayluo
Copy link
Contributor Author

rayluo commented Dec 9, 2021

We got a problem here.

azure-identity is used in Azure CLI by some modules owned by service team (though azure-cli-core doesn't depend on azure-identity), but azure-identity requires

https://github.com/Azure/azure-sdk-for-python/blob/4db8247d519b48051eb9f88d1c2c44949b6a45ba/sdk/identity/azure-identity/setup.py#L79

"msal-extensions~=0.3.0",

Azure CLI can't use msal-extensions 0.4.0, as it will cause conflict with azure-identity. @xiangyan99

Good finding, @jiasli !

  1. @xiangyan99, the msal-extensions~=0.3.0 declaration accepts msal-extensions>=0.3.0,<0.4.0. That was appropriate at that time, because Semantic Versioning allows potential breaking changes between every 0.x.0 versions. The upcoming msal-extensions 0.4.0 does not contain breaking change, so, azure-identity can simply go ahead and upgrade the dependency to msal-extensions>=0.3.0,<0.5.0.

  2. But then, @jiasli , we will also need the next version of Azure-Identity with that new widened dependency to be released, in order to let Azure CLI's modules picking up the new Azure-Identity package. So, @xiangyan99, when will next azure-identity be released?

  3. MSAL Extensions can still proceed with this 0.4.0 release. It is just that, until No.1 and No.2 above happen, the Azure CLI users would still need to manually patch their environment's msal-extensions by installing it from this github repo's dev branch.

@AzureAD AzureAD deleted a comment from jiasli Dec 11, 2021
@rayluo rayluo changed the title Release 0.4.0 Release 1.0.0 (was 0.4.0) Feb 5, 2022
@rayluo rayluo changed the title Release 1.0.0 (was 0.4.0) Release 0.4.0 Feb 5, 2022
@rayluo rayluo force-pushed the release-0.4.0 branch 4 times, most recently from 16a4897 to cda2b7c Compare February 7, 2022 08:08
@rayluo
Copy link
Contributor Author

rayluo commented Feb 14, 2022

Abandoning this PR, as we chose to go with 1.0.0 release instead.

@rayluo rayluo closed this Feb 14, 2022
@rayluo rayluo deleted the release-0.4.0 branch February 14, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants