Require Tag and internal error code for WAM errors when thrown as an Msal exception

[crmann1]

Right now in
https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/blob/4e8df7a04cdec8a21a5a8dc57439f23561ec23e1/src/client/Microsoft.Identity.Client/Platforms/uap/WamBroker/WamAdapters.cs

When an unknown broker error is encountered the error code is just "unknownbroker error". Can you attach the internal error code and the tag to the msal exception, this information is critical to diagnose wam related errors. The information is in the message, but we need it on the object in order to use it in remote telemetry.

For example the string says

"Unknown Status: Unexpected Error: 0xffffffff80070520 Context: Unexpected exception while waiting for accounts control to finish: '(pii)' Tag: 0x1f7d734b (error code -2147023584) (internal error code 528315211)"

We need the error code, internal error code and tag.

[bgavrilMS]

@crmann1 - the code that you point to is older WAM implementation, which we now only use for UWP. This is the code that transforms the WAM error into an MSAL exception

Looks like the flow goes into the default case of the switch. We can improve the actual message I think.

Is the ask to have a new exception type, where Tag and Internal Error Code are available programmatically (the Error Code can be made available even now).

[crmann1]

Yes, we need the tag and internal error code programmatically since the msal c++ folks said they are required to debug WAM related issues. From: Bogdan Gavril ***@***.***> Sent: Wednesday, April 26, 2023 4:15 AM To: AzureAD/microsoft-authentication-library-for-dotnet ***@***.***> Cc: Chris Mann ***@***.***>; Mention ***@***.***> Subject: Re: [AzureAD/microsoft-authentication-library-for-dotnet] Require Tag and internal error code for WAM errors when thrown as an Msal exception (Issue #4106) @crmann1<https://github.com/crmann1> - the code that you point to is older WAM implementation, which we now only use for UWP. This is the code that transforms the WAM error into an MSAL exception <https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/blob/main/src/client/Microsoft.Identity.Client/Platforms/Features/RuntimeBroker/WamAdapters.cs#L64> Looks like the flow goes into the default case of the switch. We can improve the actual message I think. Is the ask to have a new exception type, where Tag and Internal Error Code are available programmatically (the Error Code can be made available even now). - Reply to this email directly, view it on GitHub<#4106 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC3XZNOWGLA56X37WZZHMOLXDD7RVANCNFSM6AAAAAAXL2STDI>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>