Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Xamarin.Android.Support Libraries to 25.4.0.2+ to prevent Mono Linker issues #476

Closed
JonDouglas opened this issue Oct 2, 2017 · 1 comment

Comments

@JonDouglas
Copy link

commented Oct 2, 2017

Because the current 1.1.0-preview version of Microsoft.Identity.Client has a loose dependency on Xamarin.Android.Support libraries of >= 23.3.0, the LinkAssemblies task within Xamarin will fail because it expects a definition of:

LaunchUrl(Activity context, Uri url)

instead of the newer definition which is typically installed (i.e. 25+):

LaunchUrl(Context context, Uri url)

In other words, the following line fails by the Linker because the method definition does not exist as it has changed between 23.3.0 and 26.0.2-beta1 (I have not looked to see exactly where it changed):

Thus the following should be bumped higher:

https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/blob/master/src/Microsoft.Identity.Client/Microsoft.Identity.Client.csproj#L134-L135

Context:
https://bugzilla.xamarin.com/show_bug.cgi?id=59886

@kpanwar

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2017

@JonDouglas - this is a duplicate of #443. We already have a 1.1.1-alpha out on myget with the fix

@kpanwar kpanwar closed this Oct 2, 2017

@kpanwar kpanwar added the duplicate label Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.