catch MsalClientException when user cancels auth instead of serviceEx… #587
Conversation
| @@ -258,6 +258,12 @@ private void VerifyAuthorizationResult() | |||
| MsalErrorMessage.NoPromptFailedErrorMessage); | |||
| } | |||
|
|
|||
| if (_authorizationResult.Status == AuthorizationStatus.UserCancel) | |||
There was a problem hiding this comment.
Can you look at adding tests for this class? A unit tests should have failed when you added these lines, but it clearly did not since the PR passed. I think it is important to lock this down with unit tests because the exceptions we throw are part of the public API, i.e. if we throw a different exception from one release to the other we have broken customers' handling code.
| @@ -1049,5 +1049,66 @@ public void GetUserTest() | |||
| Assert.AreEqual(userToFind.IdentityProvider, fetchedUser.IdentityProvider); | |||
| Assert.AreEqual(userToFind.Name, fetchedUser.Name); | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| [Description("Test for AcquireToken with user canceling authentication")] | |||
| AuthenticationResult result = await app.AcquireTokenAsync(TestConstants.Scope).ConfigureAwait(false); | ||
| } | ||
| catch (MsalClientException exc) | ||
| { |
There was a problem hiding this comment.
If an exception is not thrown, your test will still pass. You can add a return statement in your catch block and an Assert.Fail("Should not reach here") at line 1082 (after the finally). Note that the finally clause is guaranteed to be executed, even if you return in catch block.
There was a problem hiding this comment.
cool...great suggestion. thanks!
…re. test class needs to be cleaned and rebuilt often -> multitargeting issues?
…caption
#583