Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme preview note and links #127

Merged
merged 1 commit into from Nov 14, 2019
Merged

Update Readme preview note and links #127

merged 1 commit into from Nov 14, 2019

Conversation

@navyasric
Copy link
Contributor

navyasric commented Nov 13, 2019

@rayluo Please review. I wanted to add a badge for the CI build as well but couldn't find the CI build link for MSAL Python. Let me know as a comment if you have it.

@navyasric navyasric requested a review from rayluo Nov 13, 2019
Copy link

jmprieur left a comment

LGTM.

README.md Outdated
|---------------
[![readthedocs](https://readthedocs.org/projects/pip/badge/)](https://msal-python.readthedocs.io/)

The Microsoft Authentication Library for Python enables applications to implement authentication flows using the [Microsoft identity platform](https://aka.ms/aaddevv2). It allows you to sign in users or apps with Microsoft identities ([Azure AD](https://azure.microsoft.com/services/active-directory/), [Microsoft Accounts](https://account.microsoft.com) and [Azure AD B2C](https://azure.microsoft.com/services/active-directory-b2c/) accounts) and obtain tokens to call Microsoft APIs such as [Microsoft Graph](https://graph.microsoft.io/) or your own APIs registered with the Microsoft identity platform. It is built using industry standard OAuth2 and OpenID Connect protocols

This comment has been minimized.

Copy link
@jmprieur

jmprieur Nov 13, 2019

to implement authentication flows => to acquire security tokens to call protected Web APIs ? Not sure if implementing auth flow is very customer focused?

This comment has been minimized.

Copy link
@navyasric

navyasric Nov 13, 2019

Author Contributor

Updated

@navyasric navyasric force-pushed the nc-readme-update branch from 284a06e to cd9362a Nov 13, 2019
Copy link
Collaborator

rayluo left a comment

Overall looks good. A minor comment below.

And this is the link to the build badge

Also the Doc badge Documentation Status

When we provide the General Availability release
we will require you to update to the General Availability version within six months,
as applications written using a preview version of library may no longer work.
| [Getting Started](https://docs.microsoft.com/azure/active-directory/develop/quickstart-v2-python-webapp) | [Docs](https://github.com/AzureAD/microsoft-authentication-library-for-python/wiki) | [Samples](https://aka.ms/aaddevsamplesv2) | [Support](README.md#community-help-and-support)

This comment has been minimized.

Copy link
@rayluo

rayluo Nov 13, 2019

Collaborator

The link https://aka.ms/aaddevsamplesv2 currently contains only 1 python sample (which is provided by Azure Function side, which is great). Do we plan on also adding our own web app sample, and all other so-called "dev samples" into there? Right now it feels like a rural area for Python. :-)

This comment has been minimized.

Copy link
@navyasric

navyasric Nov 13, 2019

Author Contributor

Good point! I will take the next action item to update that doc with links to the Python samples.
Thanks

@rayluo
rayluo approved these changes Nov 13, 2019
Copy link
Collaborator

rayluo left a comment

LGTM. 🚢

@navyasric navyasric force-pushed the nc-readme-update branch from cd9362a to bd2930b Nov 13, 2019
@navyasric navyasric force-pushed the nc-readme-update branch from bd2930b to f289d7d Nov 14, 2019
@navyasric navyasric merged commit 5ff6d83 into dev Nov 14, 2019
4 checks passed
4 checks passed
MSAL-Python-SDL-CI #20191114.1 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@navyasric navyasric deleted the nc-readme-update branch Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.