From 19b5d0cdf1984070d1bfdb66ab91ed6bf677ac42 Mon Sep 17 00:00:00 2001 From: Yue Yu Date: Tue, 11 May 2021 18:39:19 +0800 Subject: [PATCH 1/2] only validate scoring fe when inference is enabled --- src/k8s-extension/HISTORY.rst | 5 +++++ .../partner_extensions/AzureMLKubernetes.py | 3 +-- src/k8s-extension/setup.py | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/k8s-extension/HISTORY.rst b/src/k8s-extension/HISTORY.rst index 89016d5f307..e50e0508a85 100644 --- a/src/k8s-extension/HISTORY.rst +++ b/src/k8s-extension/HISTORY.rst @@ -3,6 +3,11 @@ Release History =============== +0.3.2 +++++++++++++++++++ + +* Only validate scoring fe settings when inference is enabled in microsoft.azureml.kubernetes + 0.3.1 ++++++++++++++++++ diff --git a/src/k8s-extension/azext_k8s_extension/partner_extensions/AzureMLKubernetes.py b/src/k8s-extension/azext_k8s_extension/partner_extensions/AzureMLKubernetes.py index 34d71beb829..d907e7d3c63 100644 --- a/src/k8s-extension/azext_k8s_extension/partner_extensions/AzureMLKubernetes.py +++ b/src/k8s-extension/azext_k8s_extension/partner_extensions/AzureMLKubernetes.py @@ -167,14 +167,13 @@ def __validate_config(self, configuration_settings, configuration_protected_sett if enable_inference: logger.warning("The installed AzureML extension for AML inference is experimental and not covered by customer support. Please use with discretion.") + self.__validate_scoring_fe_settings(configuration_settings, configuration_protected_settings) elif not (enable_training or enable_inference): raise InvalidArgumentValueError( "Please create Microsoft.AzureML.Kubernetes extension instance either " "for Machine Learning training or inference by specifying " f"'--configuration-settings {self.ENABLE_TRAINING}=true' or '--configuration-settings {self.ENABLE_INFERENCE}=true'") - self.__validate_scoring_fe_settings(configuration_settings, configuration_protected_settings) - configuration_settings[self.ENABLE_TRAINING] = configuration_settings.get(self.ENABLE_TRAINING, enable_training) configuration_settings[self.ENABLE_INFERENCE] = configuration_settings.get( self.ENABLE_INFERENCE, enable_inference) diff --git a/src/k8s-extension/setup.py b/src/k8s-extension/setup.py index b3512c976db..0da7edb8a26 100644 --- a/src/k8s-extension/setup.py +++ b/src/k8s-extension/setup.py @@ -32,7 +32,7 @@ # TODO: Add any additional SDK dependencies here DEPENDENCIES = [] -VERSION = "0.3.1" +VERSION = "0.3.2" with open('README.rst', 'r', encoding='utf-8') as f: README = f.read() From fa0aa821884b30cae9265b810e0613db7819b119 Mon Sep 17 00:00:00 2001 From: jonathan-innis Date: Tue, 11 May 2021 10:15:30 -0700 Subject: [PATCH 2/2] Fix versioning --- src/k8s-extension/HISTORY.rst | 6 +----- src/k8s-extension/setup.py | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/k8s-extension/HISTORY.rst b/src/k8s-extension/HISTORY.rst index e50e0508a85..02562364f13 100644 --- a/src/k8s-extension/HISTORY.rst +++ b/src/k8s-extension/HISTORY.rst @@ -3,15 +3,11 @@ Release History =============== -0.3.2 -++++++++++++++++++ - -* Only validate scoring fe settings when inference is enabled in microsoft.azureml.kubernetes - 0.3.1 ++++++++++++++++++ * Add provider registration to check to validations +* Only validate scoring fe settings when inference is enabled in microsoft.azureml.kubernetes 0.3.0 ++++++++++++++++++ diff --git a/src/k8s-extension/setup.py b/src/k8s-extension/setup.py index 0da7edb8a26..b3512c976db 100644 --- a/src/k8s-extension/setup.py +++ b/src/k8s-extension/setup.py @@ -32,7 +32,7 @@ # TODO: Add any additional SDK dependencies here DEPENDENCIES = [] -VERSION = "0.3.2" +VERSION = "0.3.1" with open('README.rst', 'r', encoding='utf-8') as f: README = f.read()