Fix tests that fail with IVerilog 12+ #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@quark17 I just ran the tests in Anyway, |
IVerilog 12+ prints a message when $finish is called without arguments. The perl scripts in the Interra operator tests didn't properly handle the extra output, leading to failure. Resolve this by calling $finish(0) to specify no message. The positive reset clock divider tests were set up wrong and were providing extra bogus file names on the command line, which earlier IVerilog warned about but didn't exit; IVerilog 12+ now exits with an error. Behavior on some extreme string examples has been fixed in v12 and v13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #561 by addressing the two test directories that fail with IVerilog v12 (and 13.0 development at the HEAD of the iverilog repo).