Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple cache for OAuth2 token validation #278

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

RadovanTomik
Copy link
Collaborator

@RadovanTomik RadovanTomik commented Apr 9, 2024

Negotiator pull request:

Description:

Adds a cache for userinfo and token introspection that is emptied every 5 minutes.

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

  • I have performed a self review of my code
  • My code follows Google Java Code style
  • I have made my code as simple as possible
  • I have added unit tests and the code coverage has not decreased
  • I have updated the documentation in all relevant places

Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
@RadovanTomik RadovanTomik requested a review from svituz April 9, 2024 15:44
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 19.04762% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 76.42%. Comparing base (9fac93e) to head (8253262).

Files Patch % Lines
...guration/security/auth/CustomJWTAuthConverter.java 0.00% 10 Missing ⚠️
...guration/security/auth/IntrospectionValidator.java 20.00% 4 Missing ⚠️
...ator/configuration/security/auth/CacheManager.java 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #278      +/-   ##
============================================
- Coverage     76.84%   76.42%   -0.43%     
- Complexity      870      871       +1     
============================================
  Files           122      123       +1     
  Lines          2721     2740      +19     
  Branches        157      158       +1     
============================================
+ Hits           2091     2094       +3     
- Misses          524      540      +16     
  Partials        106      106              
Flag Coverage Δ
unit 76.42% <19.04%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
@RadovanTomik RadovanTomik self-assigned this Apr 11, 2024
@RadovanTomik RadovanTomik linked an issue Apr 11, 2024 that may be closed by this pull request
@RadovanTomik RadovanTomik merged commit 8f8b9b9 into master Apr 11, 2024
14 of 16 checks passed
@RadovanTomik RadovanTomik deleted the feat/userinfo_cache branch April 11, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add cache for oauth2 access tokens
2 participants