From e43a43ad4d076c040f3a734d3deb901b69460c4c Mon Sep 17 00:00:00 2001
From: Hyyan Abo Fakher <hyyanaf@gmail.com>
Date: Mon, 4 Apr 2022 13:08:16 +0200
Subject: [PATCH] refactor: deprecate `PinnedRowCellRendere` BREAKING CHANGE:
 Setting the `PinnedRowCellRendere` won't affect the rendering anymore. Please
 use the `CellRenderer` instead

---
 GxColumns.bbj       | 14 ++++++++------
 demo/RowPinning.bbj | 15 +++++++++------
 2 files changed, 17 insertions(+), 12 deletions(-)

diff --git a/GxColumns.bbj b/GxColumns.bbj
index 3c0432ad..5b1db4f8 100644
--- a/GxColumns.bbj
+++ b/GxColumns.bbj
@@ -360,6 +360,8 @@ class public GxDefaultColumnDefinition extends GxColumnDefinition
     rem  *
     rem  * <br><b><small>#Configuration</small></b>
     rem  * <br><b><small>#ColumnsRenderer</small></b>
+    rem  *  
+    rem  * @deprecated since v1.7.0, Setting this value won't affect the rendering. Please use the `CellRenderer` instead.
     rem  */
     field public GxRendererInterface PinnedRowCellRenderer! = null()
     rem /**
@@ -1247,13 +1249,13 @@ class public GxDefaultColumnDefinition extends GxColumnDefinition
             column!.        add("cellRendererParams",iff(rendererParams!.entrySet().size() <> 0 , rendererParams! , null() ),err=*next)
         FI
 
-        pinnedRenderer! = #getPinnedRowCellRenderer()
+        rem pinnedRenderer! = #getPinnedRowCellRenderer()
 
-        if(pinnedRenderer! <> null()) then
-            pinnedRendererParams! = pinnedRenderer!.getAsJsonObject()
-            column!.addProperty("pinnedRowCellRenderer", pinnedRenderer!.getCellRendererName(),err=*next)
-            column!.        add("pinnedRowCellRendererParams",iff(pinnedRendererParams!.entrySet().size() <> 0 , pinnedRendererParams! , null() ),err=*next)
-        FI
+        rem if(pinnedRenderer! <> null()) then
+        rem     pinnedRendererParams! = pinnedRenderer!.getAsJsonObject()
+        rem     column!.addProperty("pinnedRowCellRenderer", pinnedRenderer!.getCellRendererName(),err=*next)
+        rem     column!.        add("pinnedRowCellRendererParams",iff(pinnedRendererParams!.entrySet().size() <> 0 , pinnedRendererParams! , null() ),err=*next)
+        rem FI
 
         editor! = #getCellEditor()
 
diff --git a/demo/RowPinning.bbj b/demo/RowPinning.bbj
index 6f21ade9..80bdad68 100644
--- a/demo/RowPinning.bbj
+++ b/demo/RowPinning.bbj
@@ -64,13 +64,16 @@ main:
 
   renderer! = new GxRendererCustomHTML("<% "+
 : "var position = params.node.rowPinned;"+
-: "var content = position.toUpperCase() + ' ' + params.column.colId + ' ' + (params.rowIndex + 1);"+
-: "var isCDNumber = params.column.colId == 'CDNUMBER';"+
-: "var style = 'font-weight: bold;font-style: italic';"+
-: "style += isCDNumber ? ';color: blue;' : ''; "+
-: "print('<div class=""ag-cell-wrapper"" style=""' + style + '"">' + content + '</div>')"+
+: "if(!position) print(params.value);"+
+: "else {"+
+: " var content = position.toUpperCase() + ' ' + params.column.colId + ' ' + (params.rowIndex + 1);"+
+: " var isCDNumber = params.column.colId == 'CDNUMBER';"+
+: " var style = 'font-weight: bold;font-style: italic';"+
+: " style += isCDNumber ? ';color: blue;' : ''; "+
+: " print('<div class=""ag-cell-wrapper"" style=""' + style + '"">' + content + '</div>')"+
+: "}" +
 : "%>")
-  grid!.getOptions().getDefaultColumnDefinition().setPinnedRowCellRenderer(renderer!)
+  grid!.getOptions().getDefaultColumnDefinition().setCellRenderer(renderer!)
 
   grid!.setData(rs!)
 return