Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[70.3] Customizer section for hero and PB callout #113

Closed
alex-418 opened this Issue Mar 11, 2019 · 9 comments

Comments

Projects
None yet
3 participants
@alex-418
Copy link
Member

commented Mar 11, 2019

Create a section in the customizer for this page, to allow setting the pages which have the featured image and excerpt for:

1.) The hero image
2.) "Creating open textbooks with PressBooks" page

@alex-418 alex-418 assigned alex-418 and unassigned alex-418 Mar 12, 2019

@ehbeattie

This comment has been minimized.

Copy link

commented Mar 12, 2019

Is there a page to view for this one?

@alex-418

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

https://helga.bccampus.ca/wp/opentextbooks/create-open-textbooks/

You can switch out the default page in these sections in the customizers "Create Open Textbooks" section.

@ehbeattie

This comment has been minimized.

Copy link

commented Mar 12, 2019

Oh, hey, cool. I've added some copy and images to play around. I notice that the title appears twice here, which is odd: https://helga.bccampus.ca/wp/opentextbooks/create-open-textbook

@alex-418

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

@ehbeattie The duplicate title is because that's the page title of the one set in the customizer... as per design in #70 it shows the title of the page, and then the title of that hero section. Assigning a different page will change that second title.... I've implemented the blue background styling via 0770b1e to make that more obvious. (please note, clearing browser cache may be required)

blue_bg

@alex-418

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

I've captured the height difference issue between the two in #120

@ehbeattie

This comment has been minimized.

Copy link

commented Mar 13, 2019

The title of the hero section should be 'Getting started" but I'm unsure where to change that. Maybe I should wait until my coffee has set in...

Change from this: Screen Shot 2019-03-13 at 6 31 02 AM

To this: Screen Shot 2019-03-13 at 6 31 55 AM

@bdolor

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

above Alex notes:

Assigning a different page will change that second title

you would perform that action in the customizer

@ehbeattie

This comment has been minimized.

Copy link

commented Mar 13, 2019

The page assigned it correct, but changing the page title didn't change the hero header title. #usererror

@bdolor

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

Here's a screen shot:

image

@alex-418 alex-418 closed this Mar 13, 2019

@alex-418 alex-418 reopened this Mar 13, 2019

@alex-418 alex-418 closed this Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.