LSF clusters have varying resource units -- toil needs to detect this and adapt accordingly #1691

Closed
mr-c opened this Issue May 25, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@mr-c
Member

mr-c commented May 25, 2017

Use of the correct units is needed at
https://github.com/BD2KGenomics/toil/blob/105aa24/src/toil/batchSystems/lsf.py#L38

mem = '' if mem is None else '-R "select[type==X86_64 && mem > ' + str(int(mem/ 1000000)) + '] rusage[mem=' + str(int(mem/ 1000000)) + ']" -M' + str(int(mem/ 1000000)) + '000'

For example -- the trailing + '000' needs to be left off when running on EBI's LSF clusters

@mr-c

This comment has been minimized.

Show comment
Hide comment
@mr-c

mr-c May 25, 2017

Member

One way to discover the units is with the following command

grep LSF_UNIT_FOR_LIMITS ${LSF_ENVDIR:-/etc}/lsf.conf | awk -F= '{print $2}'

Could some other LSF users verify this and report back what they see?

For example:

[mcrusoe@ebi-cli-001 /]$ grep LSF_UNIT_FOR_LIMITS ${LSF_ENVDIR:-/etc}/lsf.conf | awk -F= '{print $2}'
MB
Member

mr-c commented May 25, 2017

One way to discover the units is with the following command

grep LSF_UNIT_FOR_LIMITS ${LSF_ENVDIR:-/etc}/lsf.conf | awk -F= '{print $2}'

Could some other LSF users verify this and report back what they see?

For example:

[mcrusoe@ebi-cli-001 /]$ grep LSF_UNIT_FOR_LIMITS ${LSF_ENVDIR:-/etc}/lsf.conf | awk -F= '{print $2}'
MB
@mr-c

This comment has been minimized.

Show comment
Hide comment
@mr-c

mr-c May 27, 2017

Member

Here's the comprehensive solution from ipython-cluster-helper for determining varying the LSF unit size

https://github.com/roryk/ipython-cluster-helper/blob/2042f4c/cluster_helper/lsf.py#L94

Member

mr-c commented May 27, 2017

Here's the comprehensive solution from ipython-cluster-helper for determining varying the LSF unit size

https://github.com/roryk/ipython-cluster-helper/blob/2042f4c/cluster_helper/lsf.py#L94

@lordzappo

This comment has been minimized.

Show comment
Hide comment
@lordzappo

lordzappo Jun 8, 2017

Contributor

grep LSF_UNIT_FOR_LIMITS ${LSF_ENVDIR:-/etc}/lsf.conf | awk -F= '{print $2}'
GB

Contributor

lordzappo commented Jun 8, 2017

grep LSF_UNIT_FOR_LIMITS ${LSF_ENVDIR:-/etc}/lsf.conf | awk -F= '{print $2}'
GB

@mr-c mr-c referenced this issue in EBI-Metagenomics/ebi-metagenomics-cwl Jul 18, 2017

Open

toil with CWL on LSF status #57

15 of 22 tasks complete

@mr-c mr-c added the ready label Jul 18, 2017

@mr-c mr-c closed this Jul 18, 2017

@mr-c mr-c removed the ready label Jul 18, 2017

@mr-c mr-c reopened this Jul 18, 2017

@mr-c mr-c added the in progress label Jul 18, 2017

@ejacox ejacox closed this in a94dc83 Jul 20, 2017

ejacox added a commit that referenced this issue Jul 20, 2017

Merge pull request #1762 from mr-c/issues/1691_LSF_memory_units
automatically use the correct LSF units (resolves #1691)

@wafflebot wafflebot bot removed the in progress label Jul 20, 2017

adderan added a commit to adderan/toil that referenced this issue Jul 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment