Skip to content

Conversation

@BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Sep 26, 2022

Update assembly file version to 6.0

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Sep 26, 2022
@FraserGreenroyd FraserGreenroyd self-requested a review September 26, 2022 23:35
@bhombot-ci
Copy link

bhombot-ci bot commented Sep 26, 2022

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 26, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check project-compliance

There are 25 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check project-compliance

There are 9 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from a DevOps perspective after code review.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check versioning
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check versioning
  • check core
  • check null-handling
  • check serialisation
  • check ready-to-merge

There are 46 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoMAnalytics_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on SQL_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: branch-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 7 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 9afa460 into main Sep 27, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM-UptickTo60 branch September 27, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:compliance Non-conforming to code guidelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants