Skip to content

Conversation

@IsakNaslundBh
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM#1423
BHoM/BHoM_Engine#2897
BHoM/Revit_Toolkit#1266

Issues addressed by this PR

Add custom upgrader for RevitMaterialTakeoff to new VolumetricMaterialTakeoff class

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Sep 30, 2022
@IsakNaslundBh IsakNaslundBh self-assigned this Sep 30, 2022
@IsakNaslundBh IsakNaslundBh requested a review from alelom October 20, 2022 12:37
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on code changes.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 24, 2022

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check copyright-compliance
  • check core

There are 15 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2022

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 22 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 6 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit c3e29cc into main Oct 25, 2022
@IsakNaslundBh IsakNaslundBh deleted the Physical_oM-#1422-AddMaterialTakeoffClass branch October 25, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:external-api-changes Imposed changes, including from dependency across other BHoM repos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants