Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Move the overflow:hidden on standard-list into a child so the results…
… don’t get trimmed
  • Loading branch information
weotch committed Oct 10, 2017
1 parent 85509c5 commit e3020ce
Show file tree
Hide file tree
Showing 10 changed files with 39 additions and 30 deletions.
12 changes: 7 additions & 5 deletions assets/sass/form/_fieldset.scss
Expand Up @@ -86,11 +86,13 @@ fieldset, .fieldset {
// In the related sidebar, subpixel rounding issues in browsers result in
// 1px of white (from the bkgd) showing up to the right of the table at
// some browser widths. So this makes the table a smidge bigger so the
// bckground of the table header is always full bleed.
overflow: hidden;
.table {
width: calc(100% + 1px);
max-width: none;
// background of the table header is always full bleed.
.listing-wrapper {
overflow: hidden;
.table {
width: calc(100% + 1px);
max-width: none;
}
}

}
Expand Down
13 changes: 7 additions & 6 deletions dist/index.css
@@ -1,4 +1,4 @@
/*! 📝 Bukwild 💾 9.11.17 👍 */
/*! 📝 Bukwild 💾 10.10.17 👍 */
@import url(//fonts.googleapis.com/css?family=Cabin:400,700|Roboto+Slab:100,300,400);@charset "UTF-8";
/**
* Bootstrap variables
Expand Down Expand Up @@ -7451,8 +7451,7 @@ fieldset, .fieldset {
fieldset .legend > .pull-right, .fieldset .legend > .pull-right {
margin-right: -3px; } }
fieldset.standard-list, .fieldset.standard-list {
padding: 0;
overflow: hidden; }
padding: 0; }
fieldset.standard-list .legend, .fieldset.standard-list .legend {
margin: 0; }
fieldset.standard-list .listing, .fieldset.standard-list .listing {
Expand All @@ -7467,9 +7466,11 @@ fieldset, .fieldset {
fieldset.standard-list .legend > a:hover, fieldset.standard-list .legend > a:focus, .fieldset.standard-list .legend > a:hover, .fieldset.standard-list .legend > a:focus {
color: #d08a46;
border-bottom-color: #d08a46; }
fieldset.standard-list .table, .fieldset.standard-list .table {
width: calc(100% + 1px);
max-width: none; }
fieldset.standard-list .listing-wrapper, .fieldset.standard-list .listing-wrapper {
overflow: hidden; }
fieldset.standard-list .listing-wrapper .table, .fieldset.standard-list .listing-wrapper .table {
width: calc(100% + 1px);
max-width: none; }
fieldset.disabled, .fieldset.disabled {
opacity: .7; }
fieldset.disabled .legend, .fieldset.disabled .legend {
Expand Down
2 changes: 1 addition & 1 deletion dist/index.js
@@ -1,4 +1,4 @@
/*! 📝 Bukwild 💾 9.11.17 👍 */
/*! 📝 Bukwild 💾 10.10.17 👍 */
(function webpackUniversalModuleDefinition(root, factory) {
if(typeof exports === 'object' && typeof module === 'object')
module.exports = factory();
Expand Down
4 changes: 2 additions & 2 deletions dist/index.min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/index.min.js

Large diffs are not rendered by default.

13 changes: 7 additions & 6 deletions example/public/assets/decoy/index.css
@@ -1,4 +1,4 @@
/*! 📝 Bukwild 💾 9.11.17 👍 */
/*! 📝 Bukwild 💾 10.10.17 👍 */
@import url(//fonts.googleapis.com/css?family=Cabin:400,700|Roboto+Slab:100,300,400);@charset "UTF-8";
/**
* Bootstrap variables
Expand Down Expand Up @@ -7451,8 +7451,7 @@ fieldset, .fieldset {
fieldset .legend > .pull-right, .fieldset .legend > .pull-right {
margin-right: -3px; } }
fieldset.standard-list, .fieldset.standard-list {
padding: 0;
overflow: hidden; }
padding: 0; }
fieldset.standard-list .legend, .fieldset.standard-list .legend {
margin: 0; }
fieldset.standard-list .listing, .fieldset.standard-list .listing {
Expand All @@ -7467,9 +7466,11 @@ fieldset, .fieldset {
fieldset.standard-list .legend > a:hover, fieldset.standard-list .legend > a:focus, .fieldset.standard-list .legend > a:hover, .fieldset.standard-list .legend > a:focus {
color: #d08a46;
border-bottom-color: #d08a46; }
fieldset.standard-list .table, .fieldset.standard-list .table {
width: calc(100% + 1px);
max-width: none; }
fieldset.standard-list .listing-wrapper, .fieldset.standard-list .listing-wrapper {
overflow: hidden; }
fieldset.standard-list .listing-wrapper .table, .fieldset.standard-list .listing-wrapper .table {
width: calc(100% + 1px);
max-width: none; }
fieldset.disabled, .fieldset.disabled {
opacity: .7; }
fieldset.disabled .legend, .fieldset.disabled .legend {
Expand Down
2 changes: 1 addition & 1 deletion example/public/assets/decoy/index.js
@@ -1,4 +1,4 @@
/*! 📝 Bukwild 💾 9.11.17 👍 */
/*! 📝 Bukwild 💾 10.10.17 👍 */
(function webpackUniversalModuleDefinition(root, factory) {
if(typeof exports === 'object' && typeof module === 'object')
module.exports = factory();
Expand Down
4 changes: 2 additions & 2 deletions example/public/assets/decoy/index.min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion example/public/assets/decoy/index.min.js

Large diffs are not rendered by default.

15 changes: 10 additions & 5 deletions views/shared/list/_standard.php
Expand Up @@ -8,14 +8,19 @@

<?php
// Create the page title for the sidebar layout
if ($layout == 'sidebar') echo View::make('decoy::shared.list._sidebar_header', $__data)->render();
if ($layout == 'sidebar') {
echo View::make('decoy::shared.list._sidebar_header', $__data)->render();

// Create the page title for a full page layout
else if ($layout == 'full') echo View::make('decoy::shared.list._full_header', $__data)->render();
} else if ($layout == 'full') {
echo View::make('decoy::shared.list._full_header', $__data)->render();
}

// Render the full table. This could be broken up into smaller chunks but leaving
// it as is until the need arises
echo View::make('decoy::shared.list._table', $__data)->render();
// Render the full table. This could be broken up into smaller chunks but
// leaving it as is until the need arises
echo '<div class="listing-wrapper">'
.View::make('decoy::shared.list._table', $__data)->render()
.'</div>';

// Add sidebar pagination
if (!empty($layout) && $layout != 'full' && $count > count($listing)): ?>
Expand Down

0 comments on commit e3020ce

Please sign in to comment.