Repository navigation
Breaking change: allow input decks to work for both 2D and 3D #113
Description
Activity
I don't think it will break anything. The users are not required to use the new
warpx.prob_loetc. If they don't, there are no changes in behaviors. We could makewarpx.*required if that's desired.Still, it will break things like
num_particles_per_cell_each_dimwhich will now always expect 3 numbers, even in 2DWell, it's easy to maintain backward compatibility for
num_particles_per_cell_each_dim.num_particles_per_cell_each_dim.clear(); pp.getarr("num_particles_per_cell_each_dim", num_particles_per_cell_each_dim); #if (AMREX_SPACEDIM == 2) if (num_particles_per_cell_each_dim.size() == 2) { num_particles_per_cell_each_dim.resize(3); num_particles_per_cell_each_dim[2] = num_particles_per_cell_each_dim[1]; num_particles_per_cell_each_dim[1] = 1; } #endifYes, PlasmaInjector does need to be modified for 2d. But that's case independent of ParmParse.
OK, sounds good. Thanks for the above code suggestion.
- added a commit that references this issue
on Sep 9, 2022
From our Slack discussion:
It would be useful to be able to run the exact same input deck with 2D and 3D.
(In that case, when run with 2D, variables such as
geometry.prob_lo = -150.e-6 -150.e-6 -50.e-6would be read in such a way that only the first and last values would be used.)
The motivation is that it would avoid a lot of copy-paste mistake: 2D input decks are usually obtained by copy-pasting 3D input decks, and modifying variables (such as
prob_lo) by hand. However, it is easy to forget a variable, and this can have drastic consequences on the simulation.For variables that are read by AMReX - not WarpX directly - (such as
geometry.prob_lo), we should create a corresponding WarpX variable (e.g.warpx.prob_lo) and do something like this:In order to implement the above change we should:
warpxvariables, for variables read by AMReX