Skip to content

add aria-label attribute to links that open in new tab #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twhiteaker merged 1 commit into from
May 14, 2021
Merged

add aria-label attribute to links that open in new tab #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions zotero.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,9 @@ function parseZoteroResults(resultText) {
var j = i + 1
if (doi.startsWith("https://doi.org/")) {
if (dois.length == 1) {
links.push(' <a href="' + doi + '" target="_blank" rel="noopener">Data link.</a>');
links.push(' <a href="' + doi + '" target="_blank" rel="noopener" aria-label="open data in new tab">Data link.</a>');
} else {
links.push(' <a href="' + doi + '" target="_blank" rel="noopener">Data link ' + j + '.</a>');
links.push(' <a href="' + doi + '" target="_blank" rel="noopener" aria-label="open data in new tab">Data link ' + j + '.</a>');
}
}
}
Expand All @@ -172,7 +172,7 @@ function parseZoteroResults(resultText) {

function parseItemLink(url) {
if (url)
return '<a href="' + url + '" target="_blank" rel="noopener">Item link.</a>';
return '<a href="' + url + '" target="_blank" rel="noopener" aria-label="open item in new tab">Item link.</a>';
else
return "";
}
Expand Down Expand Up @@ -420,4 +420,4 @@ window.onload = function () {
initForm("zoteroSearchForm", expanded);

searchZotero(query, itemType, sort, pageStart);
};
};