Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate IsString instances #192

Closed
gdetrez opened this issue Nov 4, 2016 · 1 comment
Closed

Generate IsString instances #192

gdetrez opened this issue Nov 4, 2016 · 1 comment
Assignees
@andreasabel
Labels
enhancement Haskell
Milestone
2.8.4

Comments

@gdetrez
Copy link
Contributor

gdetrez commented Nov 4, 2016

BNFC should generate IsString instances for Ident all the user-defined token types.

That would make it easier to build trees when using BNFC to generate pretty printers for code generation.
@gdetrez gdetrez self-assigned this Nov 4, 2016
gdetrez added a commit that referenced this issue Nov 4, 2016
@gdetrez
[#192] Haskell: Generate IsString instances for token types
f58014a 
The newtype created for Ident and user-defined tokens are now instances
of IsString. This makes it easier to build tree if you want to use
bnfc's pretty printer for code generation.

Close #192
@gdetrez gdetrez mentioned this issue Nov 4, 2016
Closed
@andreasabel andreasabel mentioned this issue Jan 3, 2020
Closed
@andreasabel andreasabel added this to the 2.8.4 milestone Jan 3, 2020
@andreasabel andreasabel assigned andreasabel and unassigned gdetrez Jan 3, 2020
@andreasabel
Copy link
Member

I fixed this afresh, not using the existing solution #284, which does not merge reasonably any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreasabel andreasabel

Labels
enhancement Haskell
Projects
None yet
Milestone
2.8.4
Development

Successfully merging a pull request may close this issue.

[#192] Haskell: Generate IsString instances for token types BNFC/bnfc
2 participants
@gdetrez @andreasabel