Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C skeleton uses incorrect function names #239

Closed
justinmeiners opened this issue Oct 11, 2018 · 1 comment
Closed

C skeleton uses incorrect function names #239

justinmeiners opened this issue Oct 11, 2018 · 1 comment
Assignees
@andreasabel
Labels
bug C skeleton Issue concerning the generation of skeleton/template AST traversals
Milestone
2.8.3

Comments

@justinmeiners
Copy link
Contributor

justinmeiners commented Oct 11, 2018 •
edited

The generating code does this:
https://github.com/BNFC/bnfc/blob/master/source/src/BNFC/Backend/C/CFtoCSkel.hs#L85

But, the calling code does this:
https://github.com/BNFC/bnfc/blob/master/source/src/BNFC/Backend/C/CFtoCSkel.hs#L245

These are not the same since the first uses islower on the tail. The result is an invalid skeleton.
@justinmeiners justinmeiners mentioned this issue Oct 11, 2018
Merged
7 tasks
@andreasabel andreasabel added this to the 2.8.3 milestone Aug 27, 2019
@andreasabel
Copy link
Member

Fixed in PR #238.

@andreasabel andreasabel self-assigned this Aug 27, 2019
andreasabel added a commit that referenced this issue Aug 27, 2019
@andreasabel
[ changelog ] Justin Meiners closed #237, #238, #239
2f93d35
@andreasabel andreasabel mentioned this issue Dec 15, 2019
Closed
@andreasabel andreasabel added the skeleton Issue concerning the generation of skeleton/template AST traversals label Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreasabel andreasabel

Labels
bug C skeleton Issue concerning the generation of skeleton/template AST traversals
Projects
None yet
Milestone
2.8.3
Development

No branches or pull requests
2 participants
@andreasabel @justinmeiners