Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore Haskell GLR mode #340

Closed
2 tasks done
andreasabel opened this issue Feb 14, 2021 · 2 comments
Closed
2 tasks done

Restore Haskell GLR mode #340

andreasabel opened this issue Feb 14, 2021 · 2 comments
Assignees
@andreasabel
Labels
bug GLR Concerning the Haskell backend with --glr Haskell Makefile Concerning the generated Makefile test Concerning the generated test program
Milestone
2.9.1

Comments

@andreasabel
Copy link
Member

With the hint in haskell/happy#173 (comment), the --glr mode can be tested again.

  • Fix generated Makefile to drop happy options --ghc --coerce when --glr is used.
  • Add imports needed by GLR-specific code to generated parser Test.
@andreasabel andreasabel added bug Haskell test Concerning the generated test program GLR Concerning the Haskell backend with --glr Makefile Concerning the generated Makefile labels Feb 14, 2021
@andreasabel andreasabel added this to the 2.9.1 milestone Feb 14, 2021
@andreasabel andreasabel self-assigned this Feb 14, 2021
@andreasabel andreasabel mentioned this issue Feb 14, 2021
Open
@depsterr
Copy link

depsterr commented Dec 19, 2021 •
edited

Sorry for commenting on this dead issue, but I'm rather confused. The output of bnfc --help (version 2.9.3) states that GLR parsing is deprecated

                --glr                   Output Happy GLR parser [deprecated]

Yet, this issue is closed. Is GLR parsing supported? I was unable to find any mention of this elsewhere.

@andreasabel
Copy link
Member Author

Sorry for the confusion, @depsterr. It is still supported, but deprecated, because it is not supported well upstream (by happy).
In the future, the --glr option might be removed. So far, I am supporting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreasabel andreasabel

Labels
bug GLR Concerning the Haskell backend with --glr Haskell Makefile Concerning the generated Makefile test Concerning the generated test program
Projects
None yet
Milestone
2.9.1
Development

No branches or pull requests
2 participants
@andreasabel @depsterr