Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backends: sign generated file with BNFC's version number #373

Merged
merged 1 commit into from Jul 17, 2021

Conversation

andreasabel
Copy link
Member

@andreasabel andreasabel commented Jul 16, 2021

Printing "generated by BNFC" is now taking place uniformly in Backend.Base, rather than in the individual backends.
The backends need to supply a comment-creating function to mkfile.
The BNFC-signature includes now BNFC's version number.

.txt files are signed at the end since txt2tags treats the first lines special (as headings).

Otoh, JLex only accepts comments at the beginning (the Java preamble).

So, the default remains to sign at the beginning, which is also more customary.

Printing "generated by BNFC" is now taking place uniformly in
Backend.Base, rather than in the individual backends.
The backends need to supply a comment-creating function to @mkfile@.
The BNFC-signature includes now BNFC's version number.

.txt files are signed at the end since txt2tags treats the first lines
special (as headings).

Otoh, JLex only accepts comments at the beginning (the Java preamble).

So, the default remains to sign at the beginning, which is also more
customary.
@andreasabel andreasabel added this to the 2.9.3 milestone Jul 17, 2021
@andreasabel andreasabel self-assigned this Jul 17, 2021
@andreasabel andreasabel merged commit 53b6fed into master Jul 17, 2021
@andreasabel andreasabel deleted the sign-version branch July 17, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant