Manager: unify wxSingleInstanceChecker() lockfile

[ChristianBeer]

wxSingleInstanceChecker() uses a lockfile to determine if there is a already a Manager running. On Mac this lockfile has a custom name and is managed by BOINC. On Linux and Windows the file has a default name ("Boinc Manager") and will be placed in the users home directory. If the Manager crashes this file is not deleted and prevents another instance from starting. This is observed on Linux mainly. The wx devlopers suggested to also use a custom filename and path for Linux and windows as is already there for Mac.

The relevant places are:
BOINCGUIApp.cpp: CBOINCGUIApp::DetectDuplicateInstance()
BOINCGUIApp.cpp: CBOINCGUIApp::OnInit()
mac_installer/PostInstall.cpp: UpdateAllVisibleUsers

Also see the Debian bug: #781789

[el-gallo-azul]

If the Manager crashes this file is not deleted and prevents another instance from starting

In addition to that, the file is intermittently not deleted when: (a) the computer is shut down after "Suspending" all tasks; or (b) the computer is shut down after Quitting BOINC Manager using the "Stop running tasks when exiting the BOINC Manager" option.

[CharlieFenton]

On which platform (OS) are you seeing these situations? At least on some platforms, wxSingleInstanceChecker has safeguards for this situation by checking the process ID. Also, there is already code in the BOINC Manager to handle this for the Mac (BOINCGUIApp.cpp lines 406-434 in GIT Master branch.)

On Sep 24, 2016, at 3:47 PM, el-gallo-azul notifications@github.com wrote:

If the Manager crashes this file is not deleted and prevents another instance from starting

In addition to that, the file is intermittently not deleted when: (a) the computer is shut down after "Suspending" all tasks; or (b) the computer is shut down after Quitting BOINC Manager using the "Stop running tasks when exiting the BOINC Manager" option.

�
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[el-gallo-azul]

Linux 4.4.0-38-generic

boincmgr 7.6.31 (x64)

[RichardHaselgrove]

Then let's preserve the #3310 observations here.

https://boinc.berkeley.edu/forum_thread.php?id=13132

Steps To Reproduce

1. Crash the system
2. or (sporadically) forget to use the menu to close the Manager window

System Information (please complete the following information):

• OS: Linux - Ubuntu and Mint
• BOINC Version: unstated and v7.16.1

Maybe someone will pay some attention to the backlog then.

[kvibber]

This is still happening on Linux. I just had the same problem on Fedora today, using the distro-provided builds. The system didn't crash, but I think I might have left the manager window open the last time I rebooted.

boinc-client-7.16.11-6.fc35.x86_64
boinc-manager-7.16.11-6.fc35.x86_64

I've only been running boinc on this system for a few days, so it didn't take very long to encounter the issue.