Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android version parsing #3172

Open
JamesMolson opened this issue Jun 3, 2019 · 4 comments

Comments

@JamesMolson
Copy link
Contributor

commented Jun 3, 2019

https://github.com/BOINC/boinc/blob/master/sched/plan_class_spec.cpp#L63-L79

The above code looks for:
(Android x.y.z
or
(Android x.y

but not
(Android x

My phone reports itself as (Android 9), so the function just returns 0.
Something like

n = sscanf(p, "%d", &maj);
if (n == 1) {
return maj*10000;
}

should be added before the return 0;

@AenBleidd

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

@JamesMolson, is it possible for you to provide a patch for this? It would be very great. If not - please let me know, I could find some time to spend fixing this issue.

@TheAspens

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

Details about how to make a contribution are available at: https://github.com/BOINC/boinc-policy#development-processes

@nilsjh

This comment has been minimized.

Copy link

commented Jun 4, 2019

Thanks to @JamesMolson for spotting this! This affects the server code and scheduler, so we should add a label for the scheduler. @lfield Please review.

@nilsjh

This comment has been minimized.

Copy link

commented Jun 17, 2019

Also 8.x Android versions are affected and the server does not correctly reject .Android 8.1.0 clients even if the max client version is set to 79999.

aarch64-android-linux-gnu
<min_android_version>40100</min_android_version>
<max_android_version>79999</max_android_version>

@lfield lfield reopened this Jun 17, 2019

Android automation moved this from Done to TODO - Ready to Implement Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.