[Manager][linux] Search for skins in /usr/(local)/share/boinc-manager/skins or ./skins folders. #4811
Conversation
AenBleidd
force-pushed
the
vko_add_skins_support_of_linux
branch
3 times, most recently
from
8689efa
to
ca91c9b
Compare
|
@LocutusOfBorg, @Germano0, please review |
|
Please add screen shots |
|
@talregev, done. |
|
Thank you. |
We don't do this for any other flow, so definitely not in this PR since it has nothing with the bug that is fixed with this PR |
|
We should do this for all other flow. We will add this also for windows and mac. Also locale folder. |
|
@AenBleidd Where is the skin folder? I don't see it on our repo. |
Can you make a PR after this PR will merge? |
@talregev, I'll add it to the backlog and will decide if that is necessary |
We should. Usually I am testing the binary from CI. That why I added the c files for WebAssembly debug. |
|
why aren't such skins installed in Makefile.am? How can the packager know they are needed if the build system is not installing them? |
|
That's a very good question! Thanks, @LocutusOfBorg, I'll fix that |
|
@LocutusOfBorg Please answer on discord. Thank you :) |
AenBleidd
force-pushed
the
vko_add_skins_support_of_linux
branch
from
ca91c9b
to
a2d0795
Compare
|
Any subsequent build after boinc https://code.launchpad.net/~costamagnagianfranco/+recipe/boinc-upstream-daily Should have skins installed, but please install them from Makefile.am |
This is exactly what I am working on right now. Thanks, @LocutusOfBorg |
AenBleidd
force-pushed
the
vko_add_skins_support_of_linux
branch
from
a2d0795
to
d85be5c
Compare
…/skins or ./skins folders. This fixes BOINC#4809. Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
AenBleidd
force-pushed
the
vko_add_skins_support_of_linux
branch
from
d85be5c
to
4dba080
Compare
I download the manger with webview artifact, run it on wsl.
locale and skins folder are working.
|
Ok nice thanks! I committed the change in my packaging system to use the upstream installation path. Now the build is broken in boinc-upstream-daily until this PR is merged :) |
Can you test your build on this PR before merge? |
I can fetch different branches from BOINC/boinc, but I don't want to add new sources. Instead, I extracted the PR as patch on this link https://github.com/BOINC/boinc/pull/4811.patch and added it to the Debian packaging So, this patch will break the build once this PR is merged, and I'll just remove it. G. |
Thank you! |
|
|
|
On simple view, click "notices" brings an empty page and then the program exits... |
|
@LocutusOfBorg, is looks like this issue: #4784 |
|
mmm but I didn't switch between simple and advanced view, just clicked on "notices" |
|
@LocutusOfBorg, yeah because the real crash is happens inside wxWebView component that is used on Notices windows and Notices tab |
|
ok so the skin "issues" is fixed and working properly! |
|
@LocutusOfBorg, thank you for testing this! |
This fixes #4809.
Signed-off-by: Vitalii Koshura lestat.de.lionkur@gmail.com