Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DoubleConvert: Should not depend on DCMTK #5

Closed
jcfr opened this issue Mar 12, 2013 · 1 comment
Closed

DoubleConvert: Should not depend on DCMTK #5

jcfr opened this issue Mar 12, 2013 · 1 comment
Assignees
@Chaircrusher

Comments

@jcfr
Copy link
Contributor

jcfr commented Mar 12, 2013

See https://github.com/BRAINSia/BRAINSTools/blob/master/SuperBuild/External_DoubleConvert.cmake#L35-37

Is there any particular reason the project depends on DCMTK ?
@ghost ghost assigned Chaircrusher Mar 12, 2013
@Chaircrusher
Copy link

Fixed.

pieper pushed a commit to pieper/SlicerGitSVNArchive that referenced this issue Apr 26, 2014
@jcfr
COMP: Fix double-convert external project so that it works as intended
67f21d1 
1) The previous version was working because the double-conversion project
was exporting its build tree in the cmake package registry.

See http://www.cmake.org/cmake/help/v2.8.10/cmake.html#command:export

Since the package was exported, the find_package(double-conversion ..) within
BRAINSTools was working. Line like the following weren't not used at all:

  list(APPEND ${CMAKE_PROJECT_NAME}_SUPERBUILD_EP_VARS ${extProjName}_DIR:PATH)

2) Remove dependency to DCMTK. See BRAINSia/BRAINSTools#5

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21791 3bd1e089-480b-0410-8dfb-8563597acbee
@Hui-Xie Hui-Xie mentioned this issue Feb 12, 2017
Closed
@Hui-Xie Hui-Xie mentioned this issue Mar 7, 2017
Merged
@hjmjohnson hjmjohnson mentioned this issue Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chaircrusher Chaircrusher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcfr @Chaircrusher