BUG: catch unhandled exception to allow conversion of GE DWI data with missing gradient tags

[fedorov]

fixes issue #46 for my dataset

[hjmjohnson]

The proposed patch was very helpful in identifying what was being requested. It was, however, incomplete in its coverage of test cases, so a more complete patch was created and pushed:

30454b3

Please test and report if this fixes the problem.

[fedorov]

Hans, as I discussed in the report for #46, this patch was sub-optimal, since you didn't respond to my question which way you preferred to resolve the underlying issue.

Sorry I failed to make myself clear in #46. I tried.

Thanks for fixing the issue.

[hjmjohnson]

The one question left to address is if we can use the test data you provided as a publicly sharable data set for future testing. Was the data you made available to us suitable to be shared to the world as a reference DWI test data?

Hans

From: Andrey Fedorov <notifications@github.commailto:notifications@github.com>
Reply-To: BRAINSia/BRAINSTools <reply@reply.github.commailto:reply@reply.github.com>
Date: Saturday, June 29, 2013 4:30 PM
To: BRAINSia/BRAINSTools <BRAINSTools@noreply.github.commailto:BRAINSTools@noreply.github.com>
Cc: Hans Johnson <hans.j.johnson@gmail.commailto:hans.j.johnson@gmail.com>
Subject: Re: [BRAINSTools] BUG: catch unhandled exception to allow conversion of GE DWI data with missing gradient tags (#48)

Hans, as I discussed in the report for #46#46, this patch was sub-optimal, since you didn't respond to my question which way you preferred to resolve the underlying issue.

Sorry I failed to make myself clear in #46#46. I tried.

Thanks for fixing the issue.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/48#issuecomment-20237545.

---

Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.

---

[fedorov]

Hans, I will provide a dataset that can be shared later today or tomorrow.

[fedorov]

Hans, here is the dataset you can make publicly available for future testing: https://www.dropbox.com/s/x2xb0znf7lhlv0l/Archive.zip

[hjmjohnson]

@fedorov THANKS!

@Chaircrusher Please push this up to MIDAS with the rest of the DWI test data, and write a test case for it.

[fedorov]

@hjmjohnson: should we update the git tag for the Slicer BRAINS project?