Brian Miller BRIMIL01

Organizations

@codebreakdown
BRIMIL01 commented on pull request codebreakdown/togls#6
@BRIMIL01

@Moratorius I believe the thinking was that Togls::Rules::Boolean would be for general rule cases and any formalized, reusable rules would inherit …

BRIMIL01 commented on issue codebreakdown/togls#7
@BRIMIL01

Just include generators and a railtie. Pretty much all the stuff you listed in the readme for integration handled by the gem and loaded when rails …

BRIMIL01 commented on pull request codebreakdown/togls#6
@BRIMIL01

I think until we have some additional use cases that looks good.

BRIMIL01 commented on pull request codebreakdown/togls#6
@BRIMIL01

For some reason Togls::Rules::Block is not sitting well with me, I think it defines less of what the rule is and more of how it is built. What do y…

BRIMIL01 commented on pull request codebreakdown/togls#6
@BRIMIL01

I don't know. Explicitly creating the Boolean rule infers that we want more defined rules as opposed to using the ambiguous Togls::Rule. What is th…

BRIMIL01 commented on pull request codebreakdown/togls#6
@BRIMIL01

Sorry, Togls::Rule class should not implement anything.

BRIMIL01 commented on pull request codebreakdown/togls#6
@BRIMIL01

Looks good otherwise

BRIMIL01 commented on pull request codebreakdown/togls#6
@BRIMIL01

Much cleaner! Should Togls::Rules::Rule provide a run method that throws a NotImplemented exception?

BRIMIL01 commented on pull request codebreakdown/togls#6
@BRIMIL01

Spelling, custom not custome

BRIMIL01 commented on issue codebreakdown/togls#7
@BRIMIL01

Are there enough rails specific concerns to warrant a separate gem?

BRIMIL01 commented on pull request codebreakdown/togls#6
@BRIMIL01

:hammer:

@BRIMIL01
Add railtie and generator to create togls config file
@BRIMIL01
Added handling of ssh authentication errors
1 commit with 4 additions and 0 deletions
@BRIMIL01
BRIMIL01 commented on pull request codebreakdown/togl#2
@BRIMIL01

:+1: Looks good

BRIMIL01 commented on pull request codebreakdown/togl#1
@BRIMIL01

:+1: Looks good

BRIMIL01 deleted branch github_token_import at codebreakdown/tmuxme
@BRIMIL01
BRIMIL01 merged pull request codebreakdown/tmuxme#6
@BRIMIL01
Added key import from Github
1 commit with 226 additions and 71 deletions
BRIMIL01 opened pull request codebreakdown/tmuxme#6
@BRIMIL01
Added key import from Github
1 commit with 226 additions and 71 deletions
BRIMIL01 deleted branch add_account_management at codebreakdown/tmuxme
@BRIMIL01
BRIMIL01 merged pull request codebreakdown/tmuxme#5
@BRIMIL01
Added sidebar navigation and account management
1 commit with 246 additions and 16 deletions
BRIMIL01 opened pull request codebreakdown/tmuxme#5
@BRIMIL01
Added sidebar navigation and account management
1 commit with 246 additions and 16 deletions
@BRIMIL01
BRIMIL01 deleted branch extract_auth_into_lib at codebreakdown/tmuxme
@BRIMIL01